Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0] mig pos_journal_image. (now : pos_payment_method_image) #1021

Merged
merged 24 commits into from
Feb 22, 2024
Merged

[16.0] mig pos_journal_image. (now : pos_payment_method_image) #1021

merged 24 commits into from
Feb 22, 2024

Conversation

legalsylvain
Copy link
Contributor

  • port module pos_journal_image from 12.0 to 16.0
  • rename module and recover odoo master features

pos_payment

@legalsylvain
Copy link
Contributor Author

/ocabot migration pos_journal_image

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Jun 30, 2023
@OCA-git-bot OCA-git-bot mentioned this pull request Jun 30, 2023
Open
38 tasks
@github-actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Oct 29, 2023
@github-actions github-actions bot closed this Dec 3, 2023
@legalsylvain legalsylvain reopened this Dec 3, 2023
@legalsylvain
Copy link
Contributor Author

/ocabot rebase

@OCA-git-bot
Copy link
Contributor

Congratulations, PR rebased to 16.0.

@OCA-git-bot OCA-git-bot force-pushed the 16.0-mig-pos_journal_image branch from 728972f to ee431d0 Compare December 3, 2023 13:53
@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Dec 10, 2023
BT-cserra added a commit to brain-tec/pos that referenced this pull request Dec 15, 2023
@BT-cserra
Integrate github.com/OCA/pull/1021 into the TEST project branch
2cdbda7
BT-cserra added a commit to brain-tec/pos that referenced this pull request Dec 15, 2023
@BT-cserra
Merge pull request #482 from legalsylvain/16.0-mig-pos_journal_image
585b35a 
Integrate github.com/OCA/pull/1021 into the TEST project branch
quentinDupont
quentinDupont approved these changes Jan 26, 2024
View reviewed changes
Copy link

@quentinDupont quentinDupont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm ✔️
tested and it works well :)

@legalsylvain
Copy link
Contributor Author

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-1021-by-legalsylvain-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Jan 28, 2024
@OCA-git-bot
Merge PR #1021 into 16.0
76137d4 
Signed-off-by legalsylvain
@OCA-git-bot
Copy link
Contributor

@legalsylvain your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-1021-by-legalsylvain-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@legalsylvain legalsylvain mentioned this pull request Jan 28, 2024
Merged
@legalsylvain
Copy link
Contributor Author

/ocabot rebase

CarlesAntoli and others added 15 commits January 29, 2024 07:59
@CarlesAntoli @OCA-git-bot
Translated using Weblate (Catalan)
09f7c0f 
Currently translated at 100.0% (2 of 2 strings)

Translation: pos-12.0/pos-12.0-pos_journal_image
Translate-URL: https://translation.odoo-community.org/projects/pos-12-0/pos-12-0-pos_journal_image/ca/
@CarlesAntoli @OCA-git-bot
Translated using Weblate (Spanish)
ea788b9 
Currently translated at 100.0% (2 of 2 strings)

Translation: pos-12.0/pos-12.0-pos_journal_image
Translate-URL: https://translation.odoo-community.org/projects/pos-12-0/pos-12-0-pos_journal_image/es/
@oca-travis @OCA-git-bot
[UPD] Update pos_journal_image.pot
0c48892
@oca-transbot @OCA-git-bot
Update translation files
777a8a8 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: pos-12.0/pos-12.0-pos_journal_image
Translate-URL: https://translation.odoo-community.org/projects/pos-12-0/pos-12-0-pos_journal_image/
@legalsylvain @OCA-git-bot
[ADD] migration script
77be6cc
@legalsylvain @OCA-git-bot
[REF] adopt several modules
25a60e5
@OCA-git-bot
[UPD] README.rst
2fda721
@OCA-git-bot
pos_journal_image 12.0.1.0.1
9773181
@legalsylvain @OCA-git-bot
[FIX] migration folder should be 12.0.1.0.0 not 12.0.1.0.1 (that is t…
df30e62 
…oo recent)
@ivantodorovich @OCA-git-bot
[IMP] pre-commit run -a
7b90363
@OCA-git-bot
pos_journal_image 12.0.1.0.2
e24bb1f
@mymage @OCA-git-bot
Added translation using Weblate (Italian)
6db0f1f
@mymage @OCA-git-bot
Translated using Weblate (Italian)
7c7ed39 
Currently translated at 100.0% (2 of 2 strings)

Translation: pos-12.0/pos-12.0-pos_journal_image
Translate-URL: https://translation.odoo-community.org/projects/pos-12-0/pos-12-0-pos_journal_image/it/
@legalsylvain @OCA-git-bot
[IMP] pos_journal_image: black, isort, prettier
1478aea
@legalsylvain @OCA-git-bot
[MIG] pos_journal_image from 12.0 to 16.0
eb459ca 
- change name to pos_payment_method_image
- Add roadmap file to mention that it is useless to port this module in v17
- Adapt data structure, moving image field from account.journal to pos.payment.method to fit with V17 design
- remove migration files for V12
@OCA-git-bot
Copy link
Contributor

Congratulations, PR rebased to 16.0.

@OCA-git-bot OCA-git-bot force-pushed the 16.0-mig-pos_journal_image branch from ee431d0 to eb459ca Compare January 29, 2024 07:59
@legalsylvain
Copy link
Contributor Author

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-1021-by-legalsylvain-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Feb 20, 2024
@OCA-git-bot
Merge PR #1021 into 16.0
3883d3b 
Signed-off-by legalsylvain
@OCA-git-bot
Copy link
Contributor

@legalsylvain your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-1021-by-legalsylvain-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@pedrobaeza
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-1021-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit cc8b000 into OCA:16.0 Feb 22, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at e932781. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quentinDupont quentinDupont quentinDupont approved these changes

Assignees
No one assigned
Labels
merged 🎉
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.
9 participants
@legalsylvain @OCA-git-bot @pedrobaeza @quentinDupont @oca-travis @CarlesAntoli @oca-transbot @ivantodorovich @mymage