[IMP] disable_invalid_filters: log filter probes #373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pedrobaeza
reviewed
Jun 14, 2024
openupgradelib/openupgrade.py
Outdated
| @@ -2814,6 +2814,13 @@ def format_message(f): | |||
| with savepoint(env.cr): | |||
| # Strange artifact found in a filter | |||
| domain = f.domain.replace("%%", "%") | |||
| if verbose: | |||
| logger.info( | |||
| "Probing filter '%s' on model %s with domain %s", | |||
There was a problem hiding this comment.
Suggested change
| "Probing filter '%s' on model %s with domain %s", | |
| "Checking filter '%s' on model %s with domain %s", |
Probing is not a valid gerund: https://translate.google.com/details?sl=en&tl=es&text=probing&op=translate
chienandalu
force-pushed
the
imp-log-disable_invalid_filters-probing
branch
from
f6e048f to
7075908
Compare
pedrobaeza
reviewed
Jun 14, 2024
openupgradelib/openupgrade.py
Outdated
| @@ -2814,6 +2814,13 @@ def format_message(f): | |||
| with savepoint(env.cr): | |||
| # Strange artifact found in a filter | |||
| domain = f.domain.replace("%%", "%") | |||
| if verbose: | |||
There was a problem hiding this comment.
I think you should add the message at the beginning of the loop.
To have a hint on possible bottleneck issues for filters with heavy queries. We can disable it setting the new `verbose` parameter to `False`.
chienandalu
force-pushed
the
imp-log-disable_invalid_filters-probing
branch
from
7075908 to
fb69382
Compare
pedrobaeza
approved these changes
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To have a hint on possible bottleneck issues for filters with heavy queries. We can disable it setting the new
verboseparameter toFalse.cc @Tecnativa TT46020
check @pedrobaeza