Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][MIG] mrp_production_serial_matrix #1443

Merged
merged 21 commits into from
Mar 18, 2025

Conversation

DavidJForgeFlow
Copy link
Contributor

Split the wizard into two parts to avoid a bug with many2many and onchange in a wizard.
For the rest Standard Migration to 17.0

@ForgeFlow

Copy link
Contributor

@LoisRForgeFlow LoisRForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing on runbot, the wizard does not open as a new popup:

image

@DavidJForgeFlow DavidJForgeFlow force-pushed the 17.0-mig-mrp_production_serial_matrix branch from 32687fa to f9a0347 Compare January 9, 2025 15:34
@DavidJForgeFlow
Copy link
Contributor Author

There is an error with the web_widget_x2many_2d_matrix, seems to be deleting the domain applied to the lots (the ones that checks the allowed lots). I think this could be fixed after migration as except of the domain of the lot (which is also checked at validation) all the rest seems to be working fine.

@DavidJForgeFlow DavidJForgeFlow force-pushed the 17.0-mig-mrp_production_serial_matrix branch from f9a0347 to 3845829 Compare January 10, 2025 12:21
@JasminSForgeFlow JasminSForgeFlow force-pushed the 17.0-mig-mrp_production_serial_matrix branch 2 times, most recently from b544a3c to 997d480 Compare February 13, 2025 04:24
@DavidJForgeFlow
Copy link
Contributor Author

Issue fixed in OCA/web#3093.

Copy link
Contributor

@LoisRForgeFlow LoisRForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got the following error while testing including lots:

button_validate
    self._consume_selected_lots(move, matrix_lines)
  File "/opt/odoo/auto/addons/mrp_production_serial_matrix/wizards/mrp_production_serial_matrix.py", line 335, in _consume_selected_lots
    elif float_is_zero(ml.product_qty, precision_digits=precision_digits):
AttributeError: 'stock.move.line' object has no attribute 'product_qty'

@DavidJForgeFlow DavidJForgeFlow force-pushed the 17.0-mig-mrp_production_serial_matrix branch from 997d480 to 17892cc Compare February 24, 2025 09:03
@DavidJForgeFlow
Copy link
Contributor Author

I got the following error while testing including lots:

button_validate
    self._consume_selected_lots(move, matrix_lines)
  File "/opt/odoo/auto/addons/mrp_production_serial_matrix/wizards/mrp_production_serial_matrix.py", line 335, in _consume_selected_lots
    elif float_is_zero(ml.product_qty, precision_digits=precision_digits):
AttributeError: 'stock.move.line' object has no attribute 'product_qty'

Fixed now!

Copy link
Contributor

@LoisRForgeFlow LoisRForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works fine now! 👍

@DavidJForgeFlow DavidJForgeFlow force-pushed the 17.0-mig-mrp_production_serial_matrix branch from 17892cc to cfd5a51 Compare February 24, 2025 10:01
LoisRForgeFlow and others added 15 commits March 14, 2025 15:22
User should be able to use the matrix when the MO is reserved and
select the lots that are available plus the ones reserved
specifically for the MO.
If the component lines are changed they might differ from what it
is stated in the BoM. It is better to rely on compoent lines to
generate Matrix.

New option to decide whether to add or not products tracked by lots
to the matrix is added. Product tracked by serials are always added.
Currently translated at 100.0% (42 of 42 strings)

Translation: manufacture-14.0/manufacture-14.0-mrp_production_serial_matrix
Translate-URL: https://translation.odoo-community.org/projects/manufacture-14-0/manufacture-14-0-mrp_production_serial_matrix/it/
Currently translated at 100.0% (42 of 42 strings)

Translation: manufacture-14.0/manufacture-14.0-mrp_production_serial_matrix
Translate-URL: https://translation.odoo-community.org/projects/manufacture-14-0/manufacture-14-0-mrp_production_serial_matrix/it/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: manufacture-15.0/manufacture-15.0-mrp_production_serial_matrix
Translate-URL: https://translation.odoo-community.org/projects/manufacture-15-0/manufacture-15-0-mrp_production_serial_matrix/
OCA-git-bot and others added 5 commits March 14, 2025 15:22
@DavidJForgeFlow DavidJForgeFlow force-pushed the 17.0-mig-mrp_production_serial_matrix branch from cfd5a51 to 174dbde Compare March 14, 2025 14:22
Split the wizard into two parts to avoid a bug with many2many and onchange in a wizard.
@DavidJForgeFlow DavidJForgeFlow force-pushed the 17.0-mig-mrp_production_serial_matrix branch from 174dbde to 37ebab8 Compare March 18, 2025 09:09
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@LoisRForgeFlow
Copy link
Contributor

/ocabot migration mrp_production_serial_matrix

/ocabot merge nobump

@OCA-git-bot OCA-git-bot added this to the 17.0 milestone Mar 18, 2025
@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 17.0-ocabot-merge-pr-1443-by-LoisRForgeFlow-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot mentioned this pull request Mar 18, 2025
25 tasks
@OCA-git-bot OCA-git-bot merged commit 377eac6 into OCA:17.0 Mar 18, 2025
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 4d4379f. Thanks a lot for contributing to OCA. ❤️

@LoisRForgeFlow LoisRForgeFlow deleted the 17.0-mig-mrp_production_serial_matrix branch March 18, 2025 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants