Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[14.0][FIX] l10n_br_fiscal: refactor view company_id #3677

Merged
merged 1 commit into from
Mar 27, 2025
Merged

[14.0][FIX] l10n_br_fiscal: refactor view company_id #3677

merged 1 commit into from
Mar 27, 2025

Conversation

CristianoMafraJunior
Copy link
Member

Correção na View repetição do company_id

Antes:
print_1

Depois:
image

@OCA-git-bot
Copy link
Contributor

Hi @renatonlima,
some modules you are maintaining are being modified, check this out!

antoniospneto
antoniospneto approved these changes Mar 26, 2025
View reviewed changes
Copy link
Contributor

@antoniospneto antoniospneto left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mais 5 linhas removidas do l10n_br_fiscal. cc @rvalyi
Valeu @CristianoMafraJunior!
Obs: considero isso um fix, não refactor

@CristianoMafraJunior CristianoMafraJunior changed the title [14.0][REF] l10n_br_fiscal: refactor view company_id [14.0][FIX] l10n_br_fiscal: refactor view company_id Mar 26, 2025
@CristianoMafraJunior
Copy link
Member Author

Mais 5 linhas removidas do l10n_br_fiscal. cc @rvalyi Valeu @CristianoMafraJunior! Obs: considero isso um fix, não refactor

Corrigido pra FIX

rvalyi
rvalyi approved these changes Mar 26, 2025
View reviewed changes
Copy link
Member

@rvalyi rvalyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

era altamente multi-companies...

Um duplicado pelo jeito veio desse commit 1b1824a cc @mileo

Mas com certeza tb é o tipo de coisa que é facil a gente se enrolar nos ports, pensando que deu merge sem conflito enquanto ta duplicando um campo que já entrou na outra branch (não foi o caso desse me parece, mas é algo para se ligar).

Valeu.

@rvalyi rvalyi mentioned this pull request Mar 26, 2025
Merged
@renatonlima
Copy link
Member

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 14.0-ocabot-merge-pr-3677-by-renatonlima-bump-minor, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 758250c into OCA:14.0 Mar 27, 2025
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 0f80f8d. Thanks a lot for contributing to OCA. ❤️

@rvalyi rvalyi mentioned this pull request Mar 28, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rvalyi rvalyi rvalyi approved these changes

@renatonlima renatonlima renatonlima approved these changes

@antoniospneto antoniospneto antoniospneto approved these changes

Assignees
No one assigned
Labels
14.0 approved merged 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@CristianoMafraJunior @OCA-git-bot @renatonlima @rvalyi @antoniospneto