Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][ADD] helpdesk_ticket_open_tab: New module helpdesk_ticket_open_tab #678

Open
wants to merge 1 commit into
base: 16.0
Choose a base branch
from

Conversation

peluko00
Copy link
Contributor

@peluko00 peluko00 commented Jan 7, 2025

This new module add the possibility to access to the tickets from kanban view in another tab.

cc https://github.com/APSL 165322

@miquelalzanillas @lbarry-apsl @mpascuall @ppyczko @javierobcn @BernatObrador please review

Grabacion.de.pantalla.desde.2025-01-07.09-04-21.mp4

@peluko00 peluko00 force-pushed the 16.0-add-helpdesk_ticket_open_tab branch from e43eb13 to d7875aa Compare January 7, 2025 16:59
Copy link

@mpascuall mpascuall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, code review and tested in runboat

Copy link
Member

@yostashiro yostashiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional test.

It would also be interesting if web_widget_open_tab were improved to have the feature in a more generic manner, similar to how it's done for list views.

https://github.com/OCA/web/blob/af6a9b2/web_widget_open_tab/models/ir_ui_view.py#L16-L24

Copy link
Contributor

@BernatObrador BernatObrador left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

Copy link
Member

@lbarry-apsl lbarry-apsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revised

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants