Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[18.0][MIG] helpdesk_mgmt #664

Open
wants to merge 440 commits into
base: 18.0
Choose a base branch
from
Open

[18.0][MIG] helpdesk_mgmt #664

wants to merge 440 commits into from

Conversation

JasminSForgeFlow
Copy link

Standard Migration

Adapt OWL for JS

@ForgeFlow

@JasminSForgeFlow JasminSForgeFlow force-pushed the 18.0-mig-helpdesk_mgmt branch 3 times, most recently from 73b86d5 to 8d73099 Compare December 2, 2024 07:11
@JasminSForgeFlow JasminSForgeFlow mentioned this pull request Dec 2, 2024
Open
@LoisRForgeFlow
Copy link
Contributor

@JasminSForgeFlow test are failing, you might need to have a look.

@JasminSForgeFlow
Copy link
Author

@JasminSForgeFlow test are failing, you might need to have a look.

in the log I can't find the error statement, do you have access to the full log?

@JasminSForgeFlow
Copy link
Author

@JasminSForgeFlow test are failing, you might need to have a look.

After changes, tests are passing but still job is failing don't know why
https://github.com/OCA/helpdesk/actions/runs/12154623046/job/33894680859?pr=664#step:8:218

@kobros-tech kobros-tech mentioned this pull request Jan 5, 2025
Closed
@pedrobaeza
Copy link
Member

Please check CI and include latest 17.0 changes, including #693

@kobros-tech
Copy link

Please check CI and include latest 17.0 changes, including #693

@pedrobaeza

I wish if @JasminSForgeFlow add the updates and fixes too from #676 that I made and append my commits to the ones here for migration.

Better for us to agree on one single PR to work on and get it merged successfully, isn't it 🤍?

@pedrobaeza
Copy link
Member

The first PR has precedence as gentleness, but if there is no response in the coming days, we close it and take yours.

@kobros-tech
Copy link

Please check CI and include latest 17.0 changes, including #693

@pedrobaeza
please, help me to get this PR #694 merged, as the commit messages needs to be fixed before adding it in the migration to 18.0

@JasminSForgeFlow
Copy link
Author

Please check CI and include latest 17.0 changes, including #693

Added, Thanks

@JasminSForgeFlow
Copy link
Author

Please check CI and include latest 17.0 changes, including #693

@pedrobaeza

I wish if @JasminSForgeFlow add the updates and fixes too from #676 that I made and append my commits to the ones here for migration.

Better for us to agree on one single PR to work on and get it merged successfully, isn't it 🤍?

Added your commit, thanks

@pedrobaeza
Copy link
Member

There's also #676 claiming that "which needed to update the images, kanban card content, and kanban menu content"

@JasminSForgeFlow
Copy link
Author

There's also #676 claiming that "which needed to update the images, kanban card content, and kanban menu content"

Included that one 05ebab6

@pedrobaeza
Copy link
Member

👍

/ocabot migration helpdesk_mgmt

@OCA-git-bot OCA-git-bot added this to the 18.0 milestone Feb 7, 2025
@OCA-git-bot OCA-git-bot mentioned this pull request Feb 7, 2025
Open
1 task
@kobros-tech
Copy link

@JasminSForgeFlow
@pedrobaeza

thanks for you both, I was asked to add some commits too
#683
#687
#688

@pedrobaeza
Copy link
Member

Yes, please @JasminSForgeFlow include all the missing commits.

OCA-git-bot and others added 7 commits February 10, 2025 09:24
@OCA-git-bot @JasminSForgeFlow
helpdesk_mgmt 15.0.1.7.2
bcafe6e
@houzefa-abba @JasminSForgeFlow
[IMP] helpdesk_mgmt: Modernize ticket portal views
4abc80f 
Bring 15.0 ticket list & form views shown in portal mode in line with
those defined in the "project" module to display tasks.

While most elements remain the same, this cset also adds:
* List: group-by & search filters.
* Form: close date, assigned user, attachments.
@JasminSForgeFlow
[UPD] Update helpdesk_mgmt.pot
bb500f8
@OCA-git-bot @JasminSForgeFlow
helpdesk_mgmt 15.0.2.0.0
93977d2
@weblate @JasminSForgeFlow
Update translation files
585c6a3 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: helpdesk-15.0/helpdesk-15.0-helpdesk_mgmt
Translate-URL: https://translation.odoo-community.org/projects/helpdesk-15-0/helpdesk-15-0-helpdesk_mgmt/
@houzefa-abba @JasminSForgeFlow
Translated using Weblate (French)
32c17d9 
Currently translated at 90.7% (207 of 228 strings)

Translation: helpdesk-15.0/helpdesk-15.0-helpdesk_mgmt
Translate-URL: https://translation.odoo-community.org/projects/helpdesk-15-0/helpdesk-15-0-helpdesk_mgmt/fr/
@houzefa-abba @JasminSForgeFlow
[FIX] helpdesk_mgmt: Preserve line breaks
4e06c3e 
on tickets submitted from the portal.

Rely on `plaintext2html`, same as Odoo in its controller for message
threads (`/odoo15/addons/portal/controllers/mail.py`).

Existing portal test adapted to check this.
SMNDVC and others added 23 commits February 10, 2025 09:24
@SMNDVC @JasminSForgeFlow
Translated using Weblate (Slovak)
14b614e 
Currently translated at 100.0% (254 of 254 strings)

Translation: helpdesk-17.0/helpdesk-17.0-helpdesk_mgmt
Translate-URL: https://translation.odoo-community.org/projects/helpdesk-17-0/helpdesk-17-0-helpdesk_mgmt/sk/
@SMNDVC @JasminSForgeFlow
Translated using Weblate (Slovak)
522dcb4 
Currently translated at 100.0% (254 of 254 strings)

Translation: helpdesk-17.0/helpdesk-17.0-helpdesk_mgmt
Translate-URL: https://translation.odoo-community.org/projects/helpdesk-17-0/helpdesk-17-0-helpdesk_mgmt/sk/
@mymage @JasminSForgeFlow
Translated using Weblate (Italian)
cd0d395 
Currently translated at 100.0% (254 of 254 strings)

Translation: helpdesk-17.0/helpdesk-17.0-helpdesk_mgmt
Translate-URL: https://translation.odoo-community.org/projects/helpdesk-17-0/helpdesk-17-0-helpdesk_mgmt/it/
@victoralmau @JasminSForgeFlow
[DCK] helpdesk_mgmt: Change development_status key to Production/Stable
5362b6e
@OCA-git-bot @JasminSForgeFlow
[BOT] post-merge updates
7d7f134
@JasminSForgeFlow
[UPD] Update helpdesk_mgmt.pot
f410ce6
@weblate @JasminSForgeFlow
Update translation files
02fef7d 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: helpdesk-17.0/helpdesk-17.0-helpdesk_mgmt
Translate-URL: https://translation.odoo-community.org/projects/helpdesk-17-0/helpdesk-17-0-helpdesk_mgmt/
@victoralmau @JasminSForgeFlow
[IMP] helpdesk_mgmt: Improve tests
49763f7
@JasminSForgeFlow
[UPD] Update helpdesk_mgmt.pot
c0df5c8
@weblate @JasminSForgeFlow
Update translation files
105af02 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: helpdesk-17.0/helpdesk-17.0-helpdesk_mgmt
Translate-URL: https://translation.odoo-community.org/projects/helpdesk-17-0/helpdesk-17-0-helpdesk_mgmt/
@mymage @JasminSForgeFlow
Translated using Weblate (Italian)
567e659 
Currently translated at 99.2% (254 of 256 strings)

Translation: helpdesk-17.0/helpdesk-17.0-helpdesk_mgmt
Translate-URL: https://translation.odoo-community.org/projects/helpdesk-17-0/helpdesk-17-0-helpdesk_mgmt/it/
@etobella @JasminSForgeFlow
[FIX] helpdesk_mgmt: modify JS in order to make it compatible with we…
2d9f86d 
…bsite
@JasminSForgeFlow
[UPD] Update helpdesk_mgmt.pot
2b702c3
@OCA-git-bot @JasminSForgeFlow
[BOT] post-merge updates
35a296b
@weblate @JasminSForgeFlow
Update translation files
b080ed4 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: helpdesk-17.0/helpdesk-17.0-helpdesk_mgmt
Translate-URL: https://translation.odoo-community.org/projects/helpdesk-17-0/helpdesk-17-0-helpdesk_mgmt/
@victoralmau @JasminSForgeFlow
[FIX] helpdesk_mgmt: Correct display of avatar images in the portal
7f9fa78
@OCA-git-bot @JasminSForgeFlow
[BOT] post-merge updates
503412e
@mymage @JasminSForgeFlow
Translated using Weblate (Italian)
934fbf4 
Currently translated at 100.0% (255 of 255 strings)

Translation: helpdesk-17.0/helpdesk-17.0-helpdesk_mgmt
Translate-URL: https://translation.odoo-community.org/projects/helpdesk-17-0/helpdesk-17-0-helpdesk_mgmt/it/
@mymage @JasminSForgeFlow
Translated using Weblate (Italian)
33695cf 
Currently translated at 100.0% (255 of 255 strings)

Translation: helpdesk-17.0/helpdesk-17.0-helpdesk_mgmt
Translate-URL: https://translation.odoo-community.org/projects/helpdesk-17-0/helpdesk-17-0-helpdesk_mgmt/it/
@etobella @JasminSForgeFlow
[IMP] heldpesk_mgmt*: Update Logo
ec4319c
@OCA-git-bot @JasminSForgeFlow
[BOT] post-merge updates
87137ec
@JasminSForgeFlow
[IMP] helpdesk_mgmt: black, isort, prettier
e7220e2
@JasminSForgeFlow
[MIG] helpdesk_mgmt: Migration to 18.0
0b13d48
@JasminSForgeFlow
Copy link
Author

@JasminSForgeFlow @pedrobaeza

thanks for you both, I was asked to add some commits too #683 #687 #688

Included

victoralmau
victoralmau suggested changes Feb 10, 2025
View reviewed changes
Copy link
Member

@victoralmau victoralmau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code and functional review:
ejemplo-portal

As stated in the migration guide “You can replace the call to translate a string () with self.env._ for getting some performance improvement in some cases._” there should be changes in this regard.

helpdesk_mgmt/security/helpdesk_security.xml Outdated
Comment on lines 57 to 59
<field
name="domain_force"
>['|',('company_id','=',False),('company_id', 'in', company_ids)]</field>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<field
name="domain_force"
>['|',('company_id','=',False),('company_id', 'in', company_ids)]</field>
<field name="domain_force">[('company_id', 'in', company_ids + [False])]</field>

helpdesk_mgmt/security/helpdesk_security.xml Outdated
Comment on lines 65 to 67
<field
name="domain_force"
>['|',('company_id','=',False),('company_id', 'in', company_ids)]</field>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<field
name="domain_force"
>['|',('company_id','=',False),('company_id', 'in', company_ids)]</field>
<field name="domain_force">[('company_id', 'in', company_ids + [False])]</field>

helpdesk_mgmt/security/helpdesk_security.xml Outdated
Comment on lines 73 to 75
<field
name="domain_force"
>['|',('company_id','=',False),('company_id', 'in', company_ids)]</field>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<field
name="domain_force"
>['|',('company_id','=',False),('company_id', 'in', company_ids)]</field>
<field name="domain_force">[('company_id', 'in', company_ids + [False])]</field>

helpdesk_mgmt/security/helpdesk_security.xml Outdated
Comment on lines 81 to 83
<field
name="domain_force"
>['|',('company_id','=',False),('company_id', 'in', company_ids)]</field>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<field
name="domain_force"
>['|',('company_id','=',False),('company_id', 'in', company_ids)]</field>
<field name="domain_force">[('company_id', 'in', company_ids + [False])]</field>

helpdesk_mgmt/security/helpdesk_security.xml Outdated
Comment on lines 89 to 91
<field
name="domain_force"
>['|',('company_id','=',False),('company_id', 'in', company_ids)]</field>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<field
name="domain_force"
>['|',('company_id','=',False),('company_id', 'in', company_ids)]</field>
<field name="domain_force">[('company_id', 'in', company_ids + [False])]</field>

helpdesk_mgmt/security/helpdesk_security.xml Outdated
Comment on lines 97 to 99
<field
name="domain_force"
>['|',('company_id','=',False),('company_id', 'in', company_ids)]</field>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<field
name="domain_force"
>['|',('company_id','=',False),('company_id', 'in', company_ids)]</field>
<field name="domain_force">[('company_id', 'in', company_ids + [False])]</field>

helpdesk_mgmt/views/helpdesk_ticket_stage_views.xml Outdated
</div>
<group name="main">
<group name="main_left">
<field name="sequence" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<field name="sequence" />

IMO this field is not required.

@JasminSForgeFlow
Copy link
Author

Code and functional review: ejemplo-portal

As stated in the migration guide “You can replace the call to translate a string () with self.env._ for getting some performance improvement in some cases._” there should be changes in this regard.

All things attended.
Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@victoralmau victoralmau victoralmau requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
18.0
Development

Successfully merging this pull request may close these issues.