[17.0][MIG] helpdesk_mgmt #638

giarve · 2024-10-11T13:00:13Z

If original author is not available, superseeding #529

anybody wants to create a new icon for 17.0 style? some svg you could use https://www.svgrepo.com/svg/378347/system-help

imlopes

Thanks for this work ;)

giarve · 2024-10-24T20:21:47Z

@pedrobaeza should I rebase hard on latest 16.0 branch to remove this pandoc stuff from here? I read somewhere that's what you recommended, but I do not know if it is a must.

pedrobaeza · 2024-10-25T06:31:04Z

Do a interactive rebase over 17.0 (not 16.0), and edit the pre-commit commit, removing the .deb, and the continue the rebasing.

Currently translated at 100.0% (211 of 211 strings) Translation: helpdesk-15.0/helpdesk-15.0-helpdesk_mgmt Translate-URL: https://translation.odoo-community.org/projects/helpdesk-15-0/helpdesk-15-0-helpdesk_mgmt/es_AR/

The way it worked until the change was that these fields were populated with the customer's information when the ticket was created. And to preserve that functionality I think it is necessary to keep informing those fields when creating the ticket from the portal. Because when creating the ticket from the back-end the behavior is similar, when selecting a customer, the fields are filled automatically.

Currently translated at 76.3% (161 of 211 strings) Translation: helpdesk-15.0/helpdesk-15.0-helpdesk_mgmt Translate-URL: https://translation.odoo-community.org/projects/helpdesk-15-0/helpdesk-15-0-helpdesk_mgmt/tr/

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: helpdesk-15.0/helpdesk-15.0-helpdesk_mgmt Translate-URL: https://translation.odoo-community.org/projects/helpdesk-15-0/helpdesk-15-0-helpdesk_mgmt/

Currently translated at 100.0% (212 of 212 strings) Translation: helpdesk-15.0/helpdesk-15.0-helpdesk_mgmt Translate-URL: https://translation.odoo-community.org/projects/helpdesk-15-0/helpdesk-15-0-helpdesk_mgmt/es_AR/

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: helpdesk-15.0/helpdesk-15.0-helpdesk_mgmt Translate-URL: https://translation.odoo-community.org/projects/helpdesk-15-0/helpdesk-15-0-helpdesk_mgmt/

Currently translated at 100.0% (216 of 216 strings) Translation: helpdesk-15.0/helpdesk-15.0-helpdesk_mgmt Translate-URL: https://translation.odoo-community.org/projects/helpdesk-15-0/helpdesk-15-0-helpdesk_mgmt/es_AR/

This helps to really prioritize tickets as they will show on the top of the list or kanban. It is also more aligned with standard project tasks.

pedrobaeza

Why are you changing all the XML-IDs? That is only making difficult the migration of all the rest of the dependent modules, and some of the changes are incorrect.

For example, for views, it's correct to start the XML-ID saying the model (view), then an identifier, and finish with the type of view (for example, _form). Putting view at the end is what is incorrect.

imlopes · 2024-11-05T14:32:02Z

Why are you changing all the XML-IDs? That is only making difficult the migration of all the rest of the dependent modules, and some of the changes are incorrect.

For example, for views, it's correct to start the XML-ID saying the model (view), then an identifier, and finish with the type of view (for example, _form). Putting view at the end is what is incorrect.

@pedrobaeza can you give an example ?
I checked and on the previous version with have the _view at the end :

helpdesk/helpdesk_mgmt/views/helpdesk_dashboard_views.xml

Line 3 in 0f89658

But on this PR, we have the view type :
https://github.com/OCA/helpdesk/pull/638/files#diff-346c30f602ec791c5cec98db55dd28a4446400acb877323ee25536e72eaa4924R3

Am I missing something ?

pedrobaeza · 2024-11-05T14:36:44Z

Just look the diff of the migration commit:

Even if the previous XML-ID was not correct (which is more than the new one IMO), changing them arbitrarily is not good for avoiding errors or more work on dependent modules.

imlopes · 2024-11-05T14:50:45Z

Ahh I got it.
You're right.

giarve · 2024-11-08T11:20:03Z

yep. Demo XML-ids are okay to change I imagine? as they do not affect migrations. Otherwise there are some problems with tests and we can use this PR to suffix them according to the OCA guidelines at this point.

the rest of xml-ids are indeed unnecesary to change. they were in the original PR and now I went one by one reverting the changes.

imlopes · 2024-11-19T12:10:55Z

@pedrobaeza it seems ok to merge now. What you think @giarve ?

pedrobaeza · 2024-11-19T18:49:33Z

helpdesk_mgmt/views/helpdesk_dashboard_views.xml

@@ -100,39 +113,6 @@
                                        </div>
                                    </div>
                                </div>
-                                <div


Why are you removing this?

hand in hand with the other comment (also related to the dropdown)

pedrobaeza · 2024-11-19T18:49:44Z

helpdesk_mgmt/views/helpdesk_dashboard_views.xml

@@ -25,15 +47,6 @@
                                        </a>
                                    </div>
                                </div>
-                                <div class="o_kanban_manage_button_section">


Why removing this?

broken dropdown and at the wrong place otherwise.

OK, but is it restored then in the proper place?

yes, same file: ab81fb5#diff-346c30f602ec791c5cec98db55dd28a4446400acb877323ee25536e72eaa4924R15

helpdesk_mgmt/demo/helpdesk_demo.xml

Co-authored-by: Chandni Prajapati Khamar <chandni.prajapati.serpentcs@gmail.com>

pedrobaeza

Thanks for the changes

/ocabot merge nobump

OCA-git-bot · 2024-11-20T07:22:49Z

What a great day to merge this nice PR. Let's do it!
Prepared branch 17.0-ocabot-merge-pr-638-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot · 2024-11-20T07:27:22Z

Congratulations, your PR was merged at ad7012e. Thanks a lot for contributing to OCA. ❤️

giarve force-pushed the wvbs/17.0-mig-helpdesk_mgmt branch from f6b2819 to bcc60ca Compare October 15, 2024 12:12

This was referenced Oct 24, 2024

[17.0][MIG] helpdesk_type : Migration to 17.0 #647

Closed

[17.0][MIG] helpdesk_type: Migration to 17.0 #648

Open

imlopes approved these changes Oct 24, 2024

View reviewed changes

pedrobaeza mentioned this pull request Oct 25, 2024

[17.0] helpdesk_mgmt #529

Closed

pedrobaeza mentioned this pull request Oct 25, 2024

17.0 mig helpdesk mgmt [WIP] #646

Closed

giarve force-pushed the wvbs/17.0-mig-helpdesk_mgmt branch 3 times, most recently from 6167dc0 to 9db2f9e Compare October 26, 2024 19:45

MiquelRForgeFlow and others added 19 commits October 26, 2024 21:51

[FIX] helpdesk_mgmt: remove obsolete 'view_type'

4c07c47

helpdesk_mgmt 15.0.1.3.1

2a6c2cc

Translated using Weblate (Spanish (Argentina))

96cad6e

Currently translated at 100.0% (211 of 211 strings) Translation: helpdesk-15.0/helpdesk-15.0-helpdesk_mgmt Translate-URL: https://translation.odoo-community.org/projects/helpdesk-15-0/helpdesk-15-0-helpdesk_mgmt/es_AR/

Added translation using Weblate (Turkish)

95d9748

Translated using Weblate (Turkish)

f452a46

Currently translated at 76.3% (161 of 211 strings) Translation: helpdesk-15.0/helpdesk-15.0-helpdesk_mgmt Translate-URL: https://translation.odoo-community.org/projects/helpdesk-15-0/helpdesk-15-0-helpdesk_mgmt/tr/

[IMP] helpdesk_mgmt: search tickets from both number and name

e421272

[UPD] Update helpdesk_mgmt.pot

4dac320

helpdesk_mgmt 15.0.1.4.0

d9a2e09

Update translation files

dbfa591

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: helpdesk-15.0/helpdesk-15.0-helpdesk_mgmt Translate-URL: https://translation.odoo-community.org/projects/helpdesk-15-0/helpdesk-15-0-helpdesk_mgmt/

Point to correct dir in migration scripts

2b4fc31

Translated using Weblate (Spanish (Argentina))

2e077cc

Currently translated at 100.0% (212 of 212 strings) Translation: helpdesk-15.0/helpdesk-15.0-helpdesk_mgmt Translate-URL: https://translation.odoo-community.org/projects/helpdesk-15-0/helpdesk-15-0-helpdesk_mgmt/es_AR/

[FIX] helpdesk_mgmt: Fix share action on tickets.

0d2e54c

[UPD] Update helpdesk_mgmt.pot

3589814

helpdesk_mgmt 15.0.1.4.1

6ab259b

Update translation files

b44b64c

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: helpdesk-15.0/helpdesk-15.0-helpdesk_mgmt Translate-URL: https://translation.odoo-community.org/projects/helpdesk-15-0/helpdesk-15-0-helpdesk_mgmt/

Translated using Weblate (Spanish (Argentina))

f068190

Currently translated at 100.0% (216 of 216 strings) Translation: helpdesk-15.0/helpdesk-15.0-helpdesk_mgmt Translate-URL: https://translation.odoo-community.org/projects/helpdesk-15-0/helpdesk-15-0-helpdesk_mgmt/es_AR/

[IMP] helpdesk_mgmt: order by priority firts.

808b018

This helps to really prioritize tickets as they will show on the top of the list or kanban. It is also more aligned with standard project tasks.

helpdesk_mgmt 15.0.1.5.0

3831b65

OCA-git-bot added this to the 17.0 milestone Nov 5, 2024

OCA-git-bot mentioned this pull request Nov 5, 2024

Migration to version 17.0 #523

Open

7 tasks

pedrobaeza requested changes Nov 5, 2024

View reviewed changes

OCA-git-bot removed approved ready to merge labels Nov 5, 2024

giarve force-pushed the wvbs/17.0-mig-helpdesk_mgmt branch 3 times, most recently from d1e4683 to 3b9adc8 Compare November 8, 2024 11:15

imlopes mentioned this pull request Nov 19, 2024

[17.0][MIG] helpdesk_motive: Migration to 17.0 #657

Open

giarve requested a review from pedrobaeza November 19, 2024 13:37

pedrobaeza reviewed Nov 19, 2024

View reviewed changes

giarve force-pushed the wvbs/17.0-mig-helpdesk_mgmt branch from 3b9adc8 to 549c211 Compare November 19, 2024 19:34

[MIG] helpdesk_mgmt: Migration to 17.0

ab81fb5

Co-authored-by: Chandni Prajapati Khamar <chandni.prajapati.serpentcs@gmail.com>

giarve force-pushed the wvbs/17.0-mig-helpdesk_mgmt branch from 549c211 to ab81fb5 Compare November 19, 2024 19:44

pedrobaeza approved these changes Nov 20, 2024

View reviewed changes

OCA-git-bot added the approved label Nov 20, 2024

OCA-git-bot added the bot is merging ⏳ label Nov 20, 2024

OCA-git-bot merged commit 51b48d9 into OCA:17.0 Nov 20, 2024
7 checks passed

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Nov 20, 2024

ivantodorovich mentioned this pull request Nov 21, 2024

[17.0][MIG] helpdesk_mgmt_stage_validation: Migration to 17.0 #655

Open

ivantodorovich mentioned this pull request Dec 4, 2024

[17.0][MIG] helpdesk_mgmt_stage_server_action #650

Open

eantones mentioned this pull request Jan 22, 2025

[17.0][MIG] stock_picking_partner_ref: Migration to 17.0 nuobit/odoo-addons#451

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[17.0][MIG] helpdesk_mgmt #638

[17.0][MIG] helpdesk_mgmt #638

giarve commented Oct 11, 2024 •

edited

Loading

imlopes left a comment

giarve commented Oct 24, 2024

pedrobaeza commented Oct 25, 2024

pedrobaeza left a comment

imlopes commented Nov 5, 2024

pedrobaeza commented Nov 5, 2024

imlopes commented Nov 5, 2024

giarve commented Nov 8, 2024

imlopes commented Nov 19, 2024

pedrobaeza Nov 19, 2024

giarve Nov 19, 2024 •

edited

Loading

pedrobaeza Nov 19, 2024

giarve Nov 19, 2024

pedrobaeza Nov 19, 2024

giarve Nov 19, 2024

pedrobaeza left a comment

OCA-git-bot commented Nov 20, 2024

OCA-git-bot commented Nov 20, 2024

@@ @@ -100,39 +113,6 @@ @@
                                                       </div>
                                                   </div>
                                               </div>
-                                              <div

[17.0][MIG] helpdesk_mgmt #638

[17.0][MIG] helpdesk_mgmt #638

Conversation

giarve commented Oct 11, 2024 • edited Loading

imlopes left a comment

Choose a reason for hiding this comment

giarve commented Oct 24, 2024

pedrobaeza commented Oct 25, 2024

pedrobaeza left a comment

Choose a reason for hiding this comment

imlopes commented Nov 5, 2024

pedrobaeza commented Nov 5, 2024

imlopes commented Nov 5, 2024

giarve commented Nov 8, 2024

imlopes commented Nov 19, 2024

pedrobaeza Nov 19, 2024

Choose a reason for hiding this comment

giarve Nov 19, 2024 • edited Loading

Choose a reason for hiding this comment

pedrobaeza Nov 19, 2024

Choose a reason for hiding this comment

giarve Nov 19, 2024

Choose a reason for hiding this comment

pedrobaeza Nov 19, 2024

Choose a reason for hiding this comment

giarve Nov 19, 2024

Choose a reason for hiding this comment

pedrobaeza left a comment

Choose a reason for hiding this comment

OCA-git-bot commented Nov 20, 2024

OCA-git-bot commented Nov 20, 2024

giarve commented Oct 11, 2024 •

edited

Loading

giarve Nov 19, 2024 •

edited

Loading