[15.0][MIG]helpdesk motive #527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adasatorres
force-pushed
the
15.0-mig-helpdesk_motive
branch
from
ed01c61 to
b96ba93
Compare
moitabenfdz
suggested changes
Jan 3, 2024
There was a problem hiding this comment.
The code LGTM and it works, but you should squash the administrative commits.
Check this -> https://github.com/OCA/maintainer-tools/wiki/Merge-commits-in-pull-requests#mergesquash-the-commits-generated-by-bots-or-weblate
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
bot
added
the
stale
Co-Authored-By: Bhavesh Odedra <bodedra@opensourceintegrators.com>
Currently translated at 21.4% (3 of 14 strings) Translation: helpdesk-12.0/helpdesk-12.0-helpdesk_motive Translate-URL: https://translation.odoo-community.org/projects/helpdesk-12-0/helpdesk-12-0-helpdesk_motive/pt_BR/
Currently translated at 100.0% (14 of 14 strings) Translation: helpdesk-12.0/helpdesk-12.0-helpdesk_motive Translate-URL: https://translation.odoo-community.org/projects/helpdesk-12-0/helpdesk-12-0-helpdesk_motive/pt_BR/
Currently translated at 92.9% (13 of 14 strings) Translation: helpdesk-12.0/helpdesk-12.0-helpdesk_motive Translate-URL: https://translation.odoo-community.org/projects/helpdesk-12-0/helpdesk-12-0-helpdesk_motive/es/
Currently translated at 100.0% (14 of 14 strings) Translation: helpdesk-12.0/helpdesk-12.0-helpdesk_motive Translate-URL: https://translation.odoo-community.org/projects/helpdesk-12-0/helpdesk-12-0-helpdesk_motive/es/
Currently translated at 100.0% (14 of 14 strings) Translation: helpdesk-13.0/helpdesk-13.0-helpdesk_motive Translate-URL: https://translation.odoo-community.org/projects/helpdesk-13-0/helpdesk-13-0-helpdesk_motive/es_AR/
Maintainer Task
Currently translated at 100.0% (14 of 14 strings) Translation: helpdesk-13.0/helpdesk-13.0-helpdesk_motive Translate-URL: https://translation.odoo-community.org/projects/helpdesk-13-0/helpdesk-13-0-helpdesk_motive/es/
Currently translated at 100.0% (15 of 15 strings) Translation: helpdesk-14.0/helpdesk-14.0-helpdesk_motive Translate-URL: https://translation.odoo-community.org/projects/helpdesk-14-0/helpdesk-14-0-helpdesk_motive/it/
Currently translated at 100.0% (15 of 15 strings) Translation: helpdesk-14.0/helpdesk-14.0-helpdesk_motive Translate-URL: https://translation.odoo-community.org/projects/helpdesk-14-0/helpdesk-14-0-helpdesk_motive/fr/
Currently translated at 100.0% (14 of 14 strings) Translation: helpdesk-14.0/helpdesk-14.0-helpdesk_motive Translate-URL: https://translation.odoo-community.org/projects/helpdesk-14-0/helpdesk-14-0-helpdesk_motive/es_AR/
Currently translated at 100.0% (14 of 14 strings) Translation: helpdesk-14.0/helpdesk-14.0-helpdesk_motive Translate-URL: https://translation.odoo-community.org/projects/helpdesk-14-0/helpdesk-14-0-helpdesk_motive/es_AR/
After OCA@d053593 `_onchange_dominion_user_id` has been removed in helpdesk_mgmt, so it cannot be extended anymore in helpdesk_motive.
Currently translated at 100.0% (15 of 15 strings) Translation: helpdesk-14.0/helpdesk-14.0-helpdesk_motive Translate-URL: https://translation.odoo-community.org/projects/helpdesk-14-0/helpdesk-14-0-helpdesk_motive/pt/
Currently translated at 100.0% (14 of 14 strings) Translation: helpdesk-14.0/helpdesk-14.0-helpdesk_motive Translate-URL: https://translation.odoo-community.org/projects/helpdesk-14-0/helpdesk-14-0-helpdesk_motive/es/
adasatorres
force-pushed
the
15.0-mig-helpdesk_motive
branch
from
b96ba93 to
65bb921
Compare
marcelsavegnago
requested review from
max3903 and
nelsonramirezs
and removed request for
moitabenfdz
|
/ocabot migration helpdesk_motive |
max3903
approved these changes
May 31, 2024
|
/ocabot merge nobump |
|
This PR looks fantastic, let's merge it! |
|
Congratulations, your PR was merged at 9b2ecd3. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change onchange per compute, and created tests.