[16.0][FIX] account_cutoff_accrual_sale : Fixes for SO invoiced on order + [ADD] support for down payment #326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbaudoux
force-pushed
the
16-fix-account_cutoff_policy_sale
branch
2 times, most recently
from
5c23391 to
2f87938
Compare
Validate service invoice to only test stock products
Properly compute accruals when the invoice policy is on order. For service, consider it should be invoiced once confirmed. For stock, make accruals if the invoice and delivered quantity are not on the same period.
jbaudoux
force-pushed
the
16-fix-account_cutoff_policy_sale
branch
2 times, most recently
from
d408392 to
46f2288
Compare
Module does not depend on stock
Fix account_cutoff_accrual_order_base that does not depend on stock. Code moved here
Fix account_cutoff_accrual_order_base that does not depend on stock. Code moved here
jbaudoux
force-pushed
the
16-fix-account_cutoff_policy_sale
branch
from
46f2288 to
2816a86
Compare
Add support for down payment
jbaudoux
changed the title
jbaudoux
commented
Feb 14, 2025
| self.ensure_one() | ||
| if self.product_id.invoice_policy == "order": | ||
| date = self.order_id.date_order | ||
| return date.date() |
There was a problem hiding this comment.
Need to use right TZ
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added pleeeeenty of tests !
Covering:
cc @rousseldenis @lmignon @sbidoul
Also fixed
account_cutoff_accrual_order_basethat was updating stock in the test while not depending onstockmodule. Code moved to modules depending on this one andstockEdit: I also added support for downpayment