Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #324.
It introduces two new crates:
compression-core
: Contains theDecode
andEncode
traits.compression-codecs
: Contains the formercodec
module.I ran the changes through
cargo semver-checks
and it did not complain.Along the way, I made some decisions that may require further discussion:
async-compression
does not expose any of the data structures of the other crates. In particular, I did not move theLevel
enum and the moduleszstd
andbrotli
intocompression-codecs
. This enables future breaking changes incompression-codecs
without breakingasync-compression
.compression-codecs
re-exports the underlying compression libraries. The root crate does not directly depend on any of the libraries anymore. I migrated everything, including the tests, to the re-exported libraries. It may be worthwhile to add additional abstractions tocompression-codecs
to hide the underlying libraries. However, I think, that this should not be part of this PR, as it is already rather huge.