Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zstd support over Streams #13

Merged
merged 4 commits into from
May 12, 2019
Merged

Zstd support over Streams #13

merged 4 commits into from
May 12, 2019

Conversation

fairingrey
Copy link
Contributor

@fairingrey fairingrey commented May 11, 2019

Description

Adds support for compressing/decompressing Zstd over std futures' streams.

Motivation and Context

Helps contribute to #12. While Zstd isn't exactly well-known in the HTTP compression space, adding support for it would be nice for anyone who wants to use it, as it is comparable to (and at times, faster than) Brotli.

How Has This Been Tested?

Tests are provided!

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@fairingrey fairingrey mentioned this pull request May 11, 2019
Merged
8 tasks
@fairingrey fairingrey marked this pull request as ready for review May 12, 2019 06:07
@fairingrey
Copy link
Contributor Author

r? @Nemo157

You can do it after #14 is merged, since I rebased all my commits here on top of yours 😄

@fairingrey
Copy link
Contributor Author

fairingrey commented May 12, 2019

Actually, I still might probably change the API by including which encoding level to pick, similar to Brotli, but other than that I think it should be good to go.

EDIT: Done

@Nemo157
Copy link
Member

Nemo157 commented May 12, 2019

LGTM other than that one comment 👍

@Nemo157 Nemo157 merged commit 928a836 into Nullus157:master May 12, 2019
@fairingrey fairingrey deleted the zstd branch May 12, 2019 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants