Skip to content

Commit

Permalink
reverted devcontainer.json
Browse files Browse the repository at this point in the history
  • Loading branch information
Jens Plüddemann committed Sep 17, 2024
1 parent c2e8404 commit a4b50cf
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 12 deletions.
12 changes: 6 additions & 6 deletions .devcontainer/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@ FROM maven:3-eclipse-temurin-21 AS dind
ARG DEBIAN_FRONTEND=noninteractive
ENV PIP_ROOT_USER_ACTION=ignore

RUN set -eux; \
apt-get update; \
RUN set -eux && \
apt-get update && \
apt-get install -y --no-install-recommends \
sudo \
ca-certificates \
Expand All @@ -27,20 +27,20 @@ RUN update-alternatives --set ip6tables /usr/sbin/ip6tables-legacy

VOLUME /var/lib/docker

RUN apt-get update; \
RUN apt-get update && \
apt-get install --yes --no-install-recommends \
sudo \
bash \
curl \
build-essential \
python3 \
python3.12 \
python-is-python3 \
python3-dev \
python3-pip \
python3-setuptools \
python3-wheel \
python3-psutil; \
apt clean; \
python3-psutil && \
apt clean && \
rm -rf /var/lib/apt/lists/*

RUN rm -rf /usr/lib/python3*/EXTERNALLY-MANAGED
Expand Down
5 changes: 1 addition & 4 deletions .devcontainer/devcontainer.json
Original file line number Diff line number Diff line change
@@ -1,10 +1,7 @@
{
"name": "otel-getting-started",
"workspaceFolder": "/workspaces/opentelemetry-training/exercises",
// "image": "ghcr.io/novatecconsulting/opentelemetry-training-application:latest",
"build": {
"dockerfile": "Dockerfile"
},
"image": "ghcr.io/novatecconsulting/opentelemetry-training-application:latest",
"overrideCommand": false,
"runArgs": [
"--privileged"
Expand Down
2 changes: 1 addition & 1 deletion exercises/collector/initial/docker-compose.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
services:
otelcol:
image: otel/opentelemetry-collector-contrib:0.97.0
image: otel/opentelemetry-collector-contrib:0.109.0
restart: unless-stopped
command: ["--config=/etc/otel-collector-config.yml", "${OTELCOL_ARGS}"]
volumes:
Expand Down
2 changes: 1 addition & 1 deletion exercises/collector/solution/docker-compose.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
services:
otelcol:
image: otel/opentelemetry-collector-contrib:0.97.0
image: otel/opentelemetry-collector-contrib:0.109.0
restart: unless-stopped
command: ["--config=/etc/otel-collector-config.yml", "${OTELCOL_ARGS}"]
volumes:
Expand Down

0 comments on commit a4b50cf

Please sign in to comment.