Validate promise usage

.eslintrc.json

@@ -4,8 +4,9 @@
     "es2021": true
   },
   "extends": [
-    "eslint:recommended",
+    "eslint:recommended",    
     "plugin:@typescript-eslint/recommended",
+    "plugin:promise/recommended",
     "plugin:react/recommended"
   ],
   "parser": "@typescript-eslint/parser",
@@ -15,7 +16,8 @@
   },
   "plugins": [
     "@typescript-eslint",
-    "react"
+    "react",
+    "promise"
   ],
   "rules": {
     "react/react-in-jsx-scope": "off"

package.json

@@ -41,6 +41,7 @@
     "@vitejs/plugin-react": "^1.3.0",
     "eslint": "^8.53.0",
     "eslint-plugin-react": "^7.33.2",
+    "eslint-plugin-promise": "^6.1.1",
     "jest": "^29.5.0",
     "jest-environment-jsdom": "^29.5.0",
     "prettier": "^2.0.5",

src/components/Nosto404.tsx

@@ -27,15 +27,12 @@ export default function Nosto404(props: { placements?: string[] }) {
   const { renderCampaigns, pageTypeUpdated } = useRenderCampaigns("404")
 
   useNostoApi(
-    api => {
-      api
-        .defaultSession()
+    async (api) => {
+      const data = await api.defaultSession()
         .viewNotFound()
         .setPlacements(props.placements || api.placements.getPlacements())
         .load()
-        .then(data => {
-          renderCampaigns(data, api)
-        })
+      renderCampaigns(data, api)
     },
     [recommendationComponent, pageTypeUpdated]
   )

src/components/NostoCategory.tsx

@@ -30,15 +30,12 @@ export default function NostoCategory(props: { category: string; placements?: st
   const { renderCampaigns, pageTypeUpdated } = useRenderCampaigns("home")
 
   useNostoApi(
-    api => {
-      api
-        .defaultSession()
+    async (api) => {
+      const data = await api.defaultSession()
         .viewCategory(category)
         .setPlacements(placements || api.placements.getPlacements())
         .load()
-        .then(data => {
-          renderCampaigns(data, api)
-        })
+      renderCampaigns(data, api)
     },
     [category, recommendationComponent, pageTypeUpdated]
   )

src/components/NostoCheckout.tsx

@@ -27,15 +27,12 @@ export default function NostoCheckout(props: { placements?: string[] }) {
   const { renderCampaigns, pageTypeUpdated } = useRenderCampaigns("checkout")
 
   useNostoApi(
-    api => {
-      api
-        .defaultSession()
+    async (api) => {
+      const data = await api.defaultSession()
         .viewCart()
         .setPlacements(props.placements || api.placements.getPlacements())
         .load()
-        .then(data => {
-          renderCampaigns(data, api)
-        })
+      renderCampaigns(data, api)
     },
     [recommendationComponent, pageTypeUpdated]
   )

src/components/NostoHome.tsx

@@ -30,15 +30,12 @@ export default function NostoHome(props: { placements?: string[] }) {
   const { renderCampaigns, pageTypeUpdated } = useRenderCampaigns("home")
 
   useNostoApi(
-    api => {
-      api
-        .defaultSession()
+    async (api) => {
+      const data = await api.defaultSession()
         .viewFrontPage()
         .setPlacements(props.placements || api.placements.getPlacements())
         .load()
-        .then(data => {
-          renderCampaigns(data, api)
-        })
+      renderCampaigns(data, api)
     },
     [recommendationComponent, pageTypeUpdated]
   )

src/components/NostoOrder.tsx

@@ -32,15 +32,12 @@ export default function NostoOrder(props: {
   const { renderCampaigns, pageTypeUpdated } = useRenderCampaigns("order")
 
   useNostoApi(
-    api => {
-      api
-        .defaultSession()
+    async (api) => {
+      const data = await api.defaultSession()
         .addOrder(snakeize(order))
         .setPlacements(placements || api.placements.getPlacements())
         .load()
-        .then(data => {
-          renderCampaigns(data, api)
-        })
+      renderCampaigns(data, api)
     },
     [recommendationComponent, pageTypeUpdated]
   )

src/components/NostoOther.tsx

@@ -26,15 +26,12 @@ export default function NostoOther(props: { placements?: string[] }) {
   const { renderCampaigns, pageTypeUpdated } = useRenderCampaigns("other")
 
   useNostoApi(
-    api => {
-      api
-        .defaultSession()
+    async (api) => {
+      const data = await api.defaultSession()
         .viewOther()
         .setPlacements(props.placements || api.placements.getPlacements())
         .load()
-        .then(data => {
-          renderCampaigns(data, api)
-        })
+      renderCampaigns(data, api)
     },
     [recommendationComponent, pageTypeUpdated]
   )

src/components/NostoProduct.tsx

@@ -37,15 +37,12 @@ export default function NostoProduct(props: {
   const { renderCampaigns, pageTypeUpdated } = useRenderCampaigns("product")
 
   useNostoApi(
-    api => {
-      api
-        .defaultSession()
+    async (api) => {
+      const data = await api.defaultSession()
         .viewProduct(product)
         .setPlacements(placements || api.placements.getPlacements())
         .load()
-        .then(data => {
-          renderCampaigns(data, api)
-        })
+      renderCampaigns(data, api)
     },
     [product, recommendationComponent, pageTypeUpdated],
     { deep: true }

src/components/NostoSearch.tsx

@@ -31,15 +31,12 @@ export default function NostoSearch(props: { query: string; placements?: string[
   const { renderCampaigns, pageTypeUpdated } = useRenderCampaigns("search")
 
   useNostoApi(
-    api => {
-      api
-        .defaultSession()
+    async (api) => {
+      const data = await api.defaultSession()
         .viewSearch(query)
         .setPlacements(placements || api.placements.getPlacements())
         .load()
-        .then(data => {
-          renderCampaigns(data, api)
-        })
+      renderCampaigns(data, api)
     },
     [query, recommendationComponent, pageTypeUpdated]
   )