Merge pull request #542 from Nosto/hotfix/3.11.4

Hotfix 3.11.4 - Add category tagging to product tagging & Fix hidden categories
Nosto · Dec 5, 2019 · ac5efa1 · ac5efa1
2 parents 85a5b5b + 1205cc2
commit ac5efa1
Show file tree

Hide file tree

Showing 5 changed files with 11 additions and 5 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,9 @@
 All notable changes to this project will be documented in this file. This project adheres to Semantic Versioning.
 
+### 3.11.4
+* Fix category tagging not being rendered on product detail page
+* Fix an issue when rendering category tagging for categories in which parents are hidden
+
 ### 3.11.3
 * Remove function parameter type check for compatibility with PHP < 5.6
 

diff --git a/app/code/community/Nosto/Tagging/Block/Category.php b/app/code/community/Nosto/Tagging/Block/Category.php
@@ -70,7 +70,10 @@ public function getCategory()
     {
         try {
             $category = Mage::registry('current_category');
-            return Nosto_Tagging_Model_Meta_Category_Builder::build($category);
+            if ($category) {
+                return Nosto_Tagging_Model_Meta_Category_Builder::build($category);
+            }
+            return null;
         } catch (\Exception $e) {
             Nosto_Tagging_Helper_Log::exception($e);
             return null;

diff --git a/app/code/community/Nosto/Tagging/Helper/Data.php b/app/code/community/Nosto/Tagging/Helper/Data.php
@@ -265,12 +265,10 @@ public function buildCategoryString($category)
             $categories = $category->getParentCategories();
             $path = $category->getPathInStore();
             $ids = array_reverse(explode(',', $path));
+            $data = array();
             foreach ($ids as $id) {
                 if (isset($categories[$id]) && $categories[$id]->getName()) {
                     $data[] = $categories[$id]->getName();
-                } else {
-                    $data = array();
-                    break;
                 }
             }
         }

diff --git a/app/code/community/Nosto/Tagging/etc/config.xml b/app/code/community/Nosto/Tagging/etc/config.xml
@@ -28,7 +28,7 @@
 <config>
     <modules>
         <Nosto_Tagging>
-            <version>3.11.3</version>
+            <version>3.11.4</version>
         </Nosto_Tagging>
     </modules>
     <global>

diff --git a/app/design/frontend/base/default/layout/nostotagging.xml b/app/design/frontend/base/default/layout/nostotagging.xml
@@ -85,6 +85,7 @@
     <catalog_product_view>
         <reference name="after_body_start">
             <block type="nosto_tagging/product" name="nosto.product"/>
+            <block type="nosto_tagging/category" name="nosto.category"/>
         </reference>
     </catalog_product_view>