Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows test pipeline failure on dev branch fix #432

Merged
merged 2 commits into from
Feb 25, 2025
Merged

Windows test pipeline failure on dev branch fix #432

merged 2 commits into from
Feb 25, 2025

Conversation

Lilferrit
Copy link
Contributor

@Lilferrit Lilferrit commented Feb 10, 2025

Fixed windows test pipeline failure on dev branch.

Copy link

codecov bot commented Feb 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.56%. Comparing base (ba4a8a1) to head (5cbc0f6).
Report is 2 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #432   +/-   ##
=======================================
  Coverage   94.56%   94.56%           
=======================================
  Files          14       14           
  Lines        1289     1289           
=======================================
  Hits         1219     1219           
  Misses         70       70           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Lilferrit Lilferrit marked this pull request as ready for review February 22, 2025 00:26
@Lilferrit
Copy link
Contributor Author

Turns out the fix for the windows test issue is to explicitly set the weights_only argument in torch.load, since the default changed between pytorch versions. The windows tests pass now.

@Lilferrit Lilferrit changed the title Opening this to test github windows test Windows test pipeline failure on dev branch fix Feb 22, 2025
@Lilferrit Lilferrit merged commit af9eb64 into dev Feb 25, 2025
6 checks passed
@Lilferrit Lilferrit deleted the github-test branch February 25, 2025 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants