Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Save final model #313

Closed
wsnoble opened this issue Mar 14, 2024 · 1 comment · Fixed by #340
Closed

Save final model #313

wsnoble opened this issue Mar 14, 2024 · 1 comment · Fixed by #340
Assignees
@Lilferrit
Labels
enhancement New feature or request good first issue Good for newcomers
Milestone
Casanovo v5.0.0

Comments

@wsnoble
Copy link
Contributor

wsnoble commented Mar 14, 2024

If the val_check_interval is not a factor of the total number of iterations, then the last few iterations will be wasted. Also, if the val_check_interval is bigger than the total number of iterations, then no model is saved at all. We should make sure the final model always gets saved.
@wsnoble wsnoble added enhancement New feature or request good first issue Good for newcomers labels Mar 14, 2024
@bittremieux
Copy link
Collaborator

Also related to #291.

@bittremieux bittremieux mentioned this issue Mar 18, 2024
Closed
@bittremieux bittremieux added this to the Casanovo v5.0.0 milestone May 14, 2024
@bittremieux bittremieux linked a pull request Jun 26, 2024 that will close this issue
313 save final model #340
Merged
@Lilferrit Lilferrit self-assigned this Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Lilferrit Lilferrit

Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
Casanovo v5.0.0
Development

Successfully merging a pull request may close this issue.

313 save final model Noble-Lab/casanovo
3 participants
@bittremieux @Lilferrit @wsnoble