Add German translation #187
Conversation
There was a problem hiding this comment.
Thank you for taking time to translate Mythic Metals to German! I genuinely appreciate the time spent on this. Unfortunately I have multiple issues with this translation, please see the review comments.
Due to the state of the translation I will also mark this as a draft, as I do not believe it is ready to be merged.
There was a problem hiding this comment.
Looks really nice now, awesome work!
Intending to have @gliscowo go over the translations regarding advancements if the idioms/references feel right. In the meantime I found some lines which seem untranslated, added some comments on those.
|
Bumping this issue, as it seems to be stale |
Mitigated mentioned issues
Sorry, didn't have much time lately... |
|
All good. Gonna try to get a proper review of this so its merged next week 👍 |
|
Bumping this pr, as it seems to be stale. |
|
Sorry for this taking so long. Holidays set up all my german translation reviewers to be busy, including glisco. I have found someone with more MM knowledge to finally review the translation, and it should hopefully be done in the coming days/weeks. Going to post one of the review comments here, and add the rest of them once the review is complete. |
|
Alright, I addressed most of the issues you/your second party noted. If I didn't, I should have provided comments. |
|
I addressed the previously unresolved notes. |
|
Ah thank you! Just to let you know, I plan on having this merged for the last 1.20 release, followed by porting it to 1.20.6+. |
|
If you need me to look at some changes in the translation, feel free to contact me. |
No description provided.