Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mdq: init at 0.3.1 #385510

Merged
merged 1 commit into from
Mar 10, 2025
Merged

mdq: init at 0.3.1 #385510

merged 1 commit into from
Mar 10, 2025

Conversation

DimitarNestorov
Copy link
Member

@DimitarNestorov DimitarNestorov commented Feb 27, 2025

Things done

Add https://github.com/yshavit/mdq

Tested basic functionality with:

$ nix-build --option sandbox relaxed -A mdq
/nix/store/wd22vqhirx3fibxdkw1j00sq7g9n5ji1-mdq-0.3.1
$ curl -O https://raw.githubusercontent.com/yshavit/mdq/refs/heads/main/examples/hello.md
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  1730  100  1730    0     0  85702      0 --:--:-- --:--:-- --:--:-- 86500
$ cat hello.md | ./result/bin/mdq '# Hello there'
## Hello there

In fact, I'm doing very well!
This line isn't a new paragraph, just some
wrapping that mdq should unwrap.

### Sub-section with link

This is [my referenced link][a1].

[a1]: https://example.com/reference
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ethancedwards8
Copy link
Member

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 385510


x86_64-linux

✅ 1 package built:
  • mdq

@DimitarNestorov DimitarNestorov changed the title mdq: init at 0.3.0 mdq: init at 0.3.1 Mar 2, 2025
@DimitarNestorov DimitarNestorov force-pushed the add-mdq branch 2 times, most recently from 04d61dd to 4fa2d0b Compare March 2, 2025 17:19
@DimitarNestorov DimitarNestorov added 8.has: package (new) This PR adds a new package 12.approvals: 1 This PR was reviewed and approved by one reputable person labels Mar 3, 2025
@wegank wegank removed the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Mar 3, 2025
Copy link
Contributor

@GaetanLepage GaetanLepage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@GaetanLepage
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 385510


x86_64-linux

✅ 1 package built:
  • mdq

aarch64-linux

✅ 1 package built:
  • mdq

x86_64-darwin

✅ 1 package built:
  • mdq

aarch64-darwin

✅ 1 package built:
  • mdq

@GaetanLepage GaetanLepage merged commit 360804b into NixOS:master Mar 10, 2025
42 of 43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants