jetbrains.plugins: fix darwin builds #384811
Open
+103
−82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thiagokokada
force-pushed
the
fix-idea-community
branch
from
9a4f097 to
36ccec5
Compare
|
Not sure who to ping here, but @GenericNerdyUsername @liff @theCapypara. |
github-actions
bot
added
10.rebuild-darwin: 0
thiagokokada
force-pushed
the
fix-idea-community
branch
from
36ccec5 to
49c742a
Compare
|
Looks reasonable, but I don’t have a Mac to test with. |
There were 2 issues for usage of `jetbrains.plugins.addPlugins` in darwin: - Some IDE products have spaces in name (e.g.: "IntelliJ IDEA CE"). The current code didn't escape or quoted the strings together, so it failed during build - After fixing the issue above, opening the resulting app bundle (e.g.: `open result/Applications/IntelliJ IDEA CE`) would result in an error because we modified the bundle but kept the old signature This commit fixes both those issues, the first one by quoting the IDE name using `lib.escapeShellArg` and the second one by using `darwin.autoSignDarwinBinariesHook`.
thiagokokada
force-pushed
the
fix-idea-community
branch
2 times, most recently
from
8293099 to
cef5daa
Compare
github-actions
bot
added
the
6.topic: teams
thiagokokada
commented
Feb 24, 2025
This comment was marked as outdated.
This comment was marked as outdated.
This comment has been minimized.
This comment has been minimized.
2 similar comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
While NixOS#321247 technically "fixed" JAR plugins, it fixed by creating a broken symlink. The reason it wasn't causing issues before is because the derivation before set `donFixup = true`, skipping the checks for broken symlinks in the derivation. Now that the fixup phase is re-enabled, this is causing the build to fail if you have a JAR plugin like `wakatime`. Now the symbolic links are correct, but I am not sure if this is working correctly or not.
thiagokokada
force-pushed
the
fix-idea-community
branch
from
0dc1eec to
96a6b26
Compare
So we can build it in OfBorg.
|
@ofborg build jetbrains.plugins.tests.idea-ce-with-plugins |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were 2 issues for usage of
jetbrains.plugins.addPluginsin darwin:open result/Applications/IntelliJ IDEA CE) would result in an error because we modified the bundle but kept the old signatureThis PR fixes both those issues, the first one by quoting the IDE name using
lib.escapeShellArgand the second one by usingdarwin.autoSignDarwinBinariesHook.Also it formats the code using the
nixfmt-rfc-styleand does some general clean-up in the plugin derivation.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.