Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

electron-{24,27,28,29,30}-bin: remove #384809

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

mweinelt
Copy link
Member

@mweinelt mweinelt commented Feb 24, 2025

This change removes electron-fiddle, logseq, whalebird, micropad, passky-desktop which have previously been transitively marked vulnerable when Electron 24/27/28/29/30 went EOL and blocked their removal.

for electron-fiddle @andersk
for logseq @cheeseecake
for whalebird @Weathercold
for micropad @rhysmdnz
for passky-desktop @akkesm

for electron @emilylange @yuyuyureka

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

This package has last been bumped in 2023-05 and it has been marked
vulnerable since 2023-10. We can therefore conclude it is has no place
in nixpkgs like that.
End of life in 2023-10.
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Feb 24, 2025
Last updated in 2024-04 and stuck on Electron 27, which went EOL in
in the same month. It has since blocked the Electron 27 removal.
Last updated in 2024-03 and consuming Electron 27 which went EOL in
2024-04.
Last updated in 2024-01 and using Electron 27 which went EOL in 2024-04.
EOL in 2024-04.
EOL in 2024-06.
Last updated in 2024-04 and using Electron 29 which went EOL in 2024-08.
@TomaSajt
Copy link
Contributor

I had a fix PR for electron-fiddle, but I don't use the package, so I don't really care if we drop it.

@mweinelt mweinelt changed the title electron-24-bin: remove; electron-fiddle: remove electron-{24,27,28,29,30}-bin: remove Feb 24, 2025
@github-actions github-actions bot added 10.rebuild-darwin: 1 10.rebuild-darwin: 1-10 10.rebuild-linux: 1 10.rebuild-linux: 1-10 and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants