-
-
Notifications
You must be signed in to change notification settings - Fork 15k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
electron-{24,27,28,29,30}-bin: remove #384809
Open
mweinelt
wants to merge
11
commits into
NixOS:master
Choose a base branch
from
mweinelt:electron-24-bin-drop
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+11
−643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This package has last been bumped in 2023-05 and it has been marked vulnerable since 2023-10. We can therefore conclude it is has no place in nixpkgs like that.
End of life in 2023-10.
Last updated in 2024-04 and stuck on Electron 27, which went EOL in in the same month. It has since blocked the Electron 27 removal.
yuyuyureka
approved these changes
Feb 24, 2025
Last updated in 2024-03 and consuming Electron 27 which went EOL in 2024-04.
Last updated in 2024-01 and using Electron 27 which went EOL in 2024-04.
EOL in 2024-04.
EOL in 2024-06.
Last updated in 2024-04 and using Electron 29 which went EOL in 2024-08.
I had a fix PR for electron-fiddle, but I don't use the package, so I don't really care if we drop it. |
EOL in 2024-08.
EOL in 2024-10.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change removes electron-fiddle, logseq, whalebird, micropad, passky-desktop which have previously been transitively marked vulnerable when Electron 24/27/28/29/30 went EOL and blocked their removal.
for electron-fiddle @andersk
for logseq @cheeseecake
for whalebird @Weathercold
for micropad @rhysmdnz
for passky-desktop @akkesm
for electron @emilylange @yuyuyureka
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.