fractal: save memory by building without debug symbols #384790
+6
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The debug symbols are stripped afterwards anyways, and linking with them requires extra memory
github-actions
bot
added
10.rebuild-darwin: 0
nix-owners
bot
requested review from
hedning,
jtojnar,
dasj19 and
bobby285271
|
With this I'm able to compile Fractal on an m2 air without running OOM. |
flokli
approved these changes
Feb 24, 2025
flokli
reviewed
Feb 24, 2025
| # Disable debug symbols in release builds | ||
| # The debug symbols are stripped afterwards anyways, and building with them requires extra memory | ||
| postPatch = '' | ||
| substituteInPlace Cargo.toml --replace-fail "debug = true" "#debug = true" |
There was a problem hiding this comment.
I wonder if setting the CARGO_PROFILE_RELEASE_DEBUG env var would be cleaner.
This can potentially match multiple times in that file, and the --replace-fail wouldn't start failing if only one of them stops matching.
There was a problem hiding this comment.
I don't like CARGO_PROFILE_RELEASE_DEBUG because it won't fail even if they remove the debug = true.
I can convert it to a patch instead if you want, but I think the "debug = true" matching multiple lines is rather unlikely.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The debug symbols are stripped afterwards anyways, and linking with them requires extra memory
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.