Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ytdl-sub: 2025.02.17 -> 2025.02.21 #384075

Merged
merged 1 commit into from
Feb 24, 2025
Merged

Conversation

Defelo
Copy link
Member

@Defelo Defelo commented Feb 21, 2025

Changelog: https://github.com/jmbannon/ytdl-sub/releases/tag/2025.02.21

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@Defelo
Copy link
Member Author

Defelo commented Feb 21, 2025

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 384075

Logs: https://github.com/Defelo/nixpkgs-review-gha/actions/runs/13466978297

Download packages from cache:
  • x86_64-linux
    nix-store -r --add-root nixpkgs-pr-384075-x86_64-linux \
      --option binary-caches 'https://cache.nixos.org/ https://attic.defelo.de/nixpkgs' \
      --option trusted-public-keys '
      cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
      nixpkgs:xeaAWa3crK09hMmFiygBeRmLq3hUjUShgaAwYVUEtw0=
      ' \
      /nix/store/2929ilvh8nfwp048w0cmgbwx2wgyc408-ytdl-sub-2025.02.21 \
      /nix/store/yn5y22pv24f4dim3i5307ghxz2rnhssa-ytdl-sub-2025.02.21-dist
  • aarch64-linux
    nix-store -r --add-root nixpkgs-pr-384075-aarch64-linux \
      --option binary-caches 'https://cache.nixos.org/ https://attic.defelo.de/nixpkgs' \
      --option trusted-public-keys '
      cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
      nixpkgs:xeaAWa3crK09hMmFiygBeRmLq3hUjUShgaAwYVUEtw0=
      ' \
      /nix/store/4cn6p8q4agqrgsqgpag1r13i5xkwqk1m-ytdl-sub-2025.02.21 \
      /nix/store/z50i3jc8fpycbyw921mv6syklj0x8910-ytdl-sub-2025.02.21-dist
  • x86_64-darwin
    nix-store -r --add-root nixpkgs-pr-384075-x86_64-darwin \
      --option binary-caches 'https://cache.nixos.org/ https://attic.defelo.de/nixpkgs' \
      --option trusted-public-keys '
      cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
      nixpkgs:xeaAWa3crK09hMmFiygBeRmLq3hUjUShgaAwYVUEtw0=
      ' \
      /nix/store/4l1r8mpkwv36zpnvdkkibwb9cxixnv9v-ytdl-sub-2025.02.21 \
      /nix/store/x1dsfb8i3fgqgs4dg40j4f9iig9nyf9f-ytdl-sub-2025.02.21-dist
  • aarch64-darwin
    nix-store -r --add-root nixpkgs-pr-384075-aarch64-darwin \
      --option binary-caches 'https://cache.nixos.org/ https://attic.defelo.de/nixpkgs' \
      --option trusted-public-keys '
      cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
      nixpkgs:xeaAWa3crK09hMmFiygBeRmLq3hUjUShgaAwYVUEtw0=
      ' \
      /nix/store/f204s5q2ph28kpmnnp0krdcpwa6vgv6q-ytdl-sub-2025.02.21 \
      /nix/store/8l6rvb0ds3qsia5mjvwscdlzpn67yrlh-ytdl-sub-2025.02.21-dist

x86_64-linux

✅ 2 packages built:
  • ytdl-sub
  • ytdl-sub.dist

aarch64-linux

✅ 2 packages built:
  • ytdl-sub
  • ytdl-sub.dist

x86_64-darwin

✅ 2 packages built:
  • ytdl-sub
  • ytdl-sub.dist

aarch64-darwin

✅ 2 packages built:
  • ytdl-sub
  • ytdl-sub.dist

@Defelo Defelo added 8.has: package (update) This PR updates a package to a newer version 11.by: package-maintainer This PR was created by the maintainer of the package it changes labels Feb 21, 2025
@LoCrealloc LoCrealloc added 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package labels Feb 24, 2025
@donovanglover donovanglover merged commit ad60d61 into NixOS:master Feb 24, 2025
30 of 31 checks passed
@Defelo Defelo deleted the ytdl-sub branch February 24, 2025 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: package (update) This PR updates a package to a newer version 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants