ocamlPackages.wasm_of_ocaml-compiler: init at 6.0.1 #384029
Conversation
github-actions
bot
added
6.topic: ocaml
10.rebuild-darwin: 0
| js_of_ocaml, | ||
| menhir, | ||
| menhirLib, | ||
| menhirSdk, |
There was a problem hiding this comment.
| menhirSdk, |
I think this library is not needed.
There was a problem hiding this comment.
about this: https://github.com/ocsigen/js_of_ocaml/blob/937e84920335b58a5598f222a613f62f781912f7/wasm_of_ocaml-compiler.opam#L27
they declared this dependency but its not used
|
and please set |
stepbrobd
force-pushed
the
wasm_of_ocaml
branch
from
2037796 to
a61f3d0
Compare
| ]; | ||
|
|
||
| propagatedBuildInputs = [ | ||
| js_of_ocaml |
There was a problem hiding this comment.
| js_of_ocaml | |
| js_of_ocaml-compiler |
There was a problem hiding this comment.
this works because js_of_ocaml is brought in by js_of_ocaml-compiler, and only js_of_ocaml is needed as indicated in wasm_of_ocaml-compiler.opam (some extra building is required if we use js_of_ocaml-compiler instead of js_of_ocaml)
There was a problem hiding this comment.
This is the opposite: only js_of_ocaml-compiler is needed, js_of_ocaml brings in both.
There was a problem hiding this comment.
thanks! didn't check carefully in default.nix
stepbrobd
force-pushed
the
wasm_of_ocaml
branch
from
a61f3d0 to
e06b770
Compare
|
Thanks! |
wasm_of_ocaml-compiler was merged into js_ocaml in ocsigen/js_of_ocaml#1724 and released along in 6.0.1
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.