Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustc: add wasm32v1-none target #383875

Merged
merged 1 commit into from
Feb 24, 2025
Merged

rustc: add wasm32v1-none target #383875

merged 1 commit into from
Feb 24, 2025

Conversation

andresilva
Copy link
Member

@andresilva andresilva commented Feb 21, 2025 •
edited
Loading

Fixes #383765.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@andresilva andresilva changed the base branch from master to staging February 21, 2025 09:49
@andresilva andresilva changed the title Andre/rustc wasm32v1 none rustc: add wasm32v1-none target Feb 21, 2025
alyssais
alyssais approved these changes Feb 21, 2025
View reviewed changes
Copy link
Member

@alyssais alyssais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was just working on my own PR where I went through all the targets and checked if there were any that now worked to enable, but we can go ahead with this one first while I finish it :)

@wegank wegank added 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package labels Feb 21, 2025
@andresilva
Copy link
Member Author

I built a master version of the polkadot package which I know will use the wasm32v1-none target if available. It worked successfully.

@alyssais alyssais merged commit b8de2d2 into NixOS:staging Feb 24, 2025
69 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alyssais alyssais alyssais approved these changes

@winterqt winterqt Awaiting requested review from winterqt

@Mic92 Mic92 Awaiting requested review from Mic92

@figsoda figsoda Awaiting requested review from figsoda

@zowoq zowoq Awaiting requested review from zowoq

Assignees
No one assigned
Labels
6.topic: rust 10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+ 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

rustc: add wasm32v1-none target
3 participants
@andresilva @alyssais @wegank