Stirling 0.33.1 -> 0.42.0 and minor improvments #380655
Open
+1,240
−831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
6.topic: nixos
NixOSInfra
added
the
12. first-time contribution
daedric
force-pushed
the
stirling/0.41.0
branch
from
63b6f04 to
97fca2a
Compare
daedric
changed the title
daedric
force-pushed
the
stirling/0.41.0
branch
2 times, most recently
from
4514cd8 to
9e1bda4
Compare
github-actions
bot
added
10.rebuild-darwin: 0
|
Works great, they just released 0.42.0 yesterday if you want to update |
DCsunset
reviewed
Feb 22, 2025
Will do this week and address the comments I got. |
Many bug fixes.
Before any invocation to LibreOffice ended up in trying to mkdir /run/user/<uid>/libreoffice-dbus. Since the user is not a logged one and the user not a lingering one, it always failed with a permission denied error. With this change, LibreOffice does execute and does not complain about missing /proc nor permission denied.
daedric
force-pushed
the
stirling/0.41.0
branch
from
9e1bda4 to
1497e3b
Compare
|
All done :) |
github-actions
bot
added
10.rebuild-darwin: 1
10.rebuild-darwin: 1-10
and removed
10.rebuild-darwin: 0
daedric
force-pushed
the
stirling/0.41.0
branch
from
1497e3b to
d57c5ff
Compare
daedric
force-pushed
the
stirling/0.41.0
branch
from
d57c5ff to
f1409c9
Compare
daedric
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This upgrades Stirling-PDF to 0.41.0.
Things done
Upgraded programs to 0.41.0
Depends on a LibreOffice version that does not check dbus (required to run as a service without a logged-in user)
Removed the Dynamic user from systemd unit;
Create a stirling-pdf user
Allowed the Stirling directory to be updated (Stirling-pdf can take files externally added in its customFiles directory to avoid users to always upload them. For instance signatures, stamps, etc.)
Built on platform(s)
For non-Linux: Is sandboxing enabled in
nix.conf? (See Nix manual)sandbox = relaxedsandbox = trueTested, as applicable:
Tested compilation of all packages that depend on this change using
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usageTested basic functionality of all binary files (usually in
./result/bin/)25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
Fits CONTRIBUTING.md.
I'm successfully running this version of Stirling on a private Ampere VPS.
There are still issues with LibreOffice that I can't explain yet (segfault), and if I find them before this gets merged, I'll add the fixes. In any case, this is a step closer to have it properly working.Please let me know how I can improve this contribution since it is my first :)
cc @TomaSajt since you're the maintainer :)