-
-
Notifications
You must be signed in to change notification settings - Fork 15.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nixos-rebuild-ng: implement build-image #371142
nixos-rebuild-ng: implement build-image #371142
Conversation
CC @phaer. |
d176773
to
639a5a0
Compare
639a5a0
to
b747c67
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice! Was planning to implement this next week and there it is - with tests and all, thank you! 🎉
Code LGTM - but i haven't run anything yet, but can do so tomorrow or on Tuesday.
(build-image will become much more useful once #359345 is merged in case you or other readers have time for a review)
I would appreciate the testing, especially if you can test the non-Flakes code path since I have no systems to test it. |
Successfully built images with this :)
For a simple test of the CLI, I think it's enough do to that with a minimal nixos instance? i.e. with
You could test the And given an
You could then do |
Port of #347275 to
nixos-rebuild-ng
.Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.