-
-
Notifications
You must be signed in to change notification settings - Fork 15.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci/eval: add rebuildsByPlatform to the comparison result #363751
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cc706c5
to
3e989d4
Compare
3e989d4
to
9f5f021
Compare
Test run: Mic92#40 |
It seems like the comparison step does not run. |
9f5f021
to
d8b9b00
Compare
@infinisil how can we test this in our own forks? |
@Mic92 Need to also push something on the master branch to get the eval there going |
d8b9b00
to
f65c8f7
Compare
f65c8f7
to
b64946c
Compare
6dffe9d
to
1410eea
Compare
Ah maybe the issue is that my base branch is called main and not master? |
1410eea
to
33282cd
Compare
I was able to test in my fork: |
33282cd
to
518ae8f
Compare
|
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
6.topic: continuous integration
Affects continuous integration (CI) in Nixpkgs, including Ofborg and GitHub Actions
10.rebuild-darwin: 0
This PR does not cause any packages to rebuild on Darwin
10.rebuild-linux: 0
This PR does not cause any packages to rebuild on Linux
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things done
Follow-up of #362844
This adds a new key to the JSON generated by the
compare
function.It lists the rebuilds for each platform.
This will make Mic92/nixpkgs-review#433 way easier.
cc @infinisil @Mic92
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.