fix mkShellNoCC to use packages instead of buildInputs
#1020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to: https://github.com/NixOS/nix.dev/blob/cdd059f7e5627b68a137d4de3ea98ab100bdb5a9/source/tutorials/first-steps/declarative-shell.md?plain=1#L84 >The `packages` attribute argument to `mkShellNoCC` is simply an alias for `nativeBuildInputs`. I believe NixOS#131 can be closed now. I think this is one of the last remaining instances where mkShell* uses `buildInputs`.
hsjobeki
approved these changes
Jul 14, 2024
There was a problem hiding this comment.
lgtm.
Imagine we have actual api documentation. We'd instead link to https://nixos.org/manual/nixpkgs/stable/#sec-pkgs-mkShell. Explain the concept here, link to the function interface documentation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to:
nix.dev/source/tutorials/first-steps/declarative-shell.md
Line 84 in cdd059f
I believe #131 can be closed now. I think this is one of the last remaining instances where mkShell* uses
buildInputs.