Sync Committee: BlockStorage Capacity Limit #453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In case if number of blocks stored in the `BlockStorage` increases a certain amount, state reset process failed due to violation of Badger transaction size limit: `Txn is too big to fit into one request` We need to prevent Sync Committee storage from growing indefinitely in case the prover network is down or unresponsive by introducing a capacity limit for the storage: * Introduced a configurable capacity limit for `BlockStorage` with default settings and validation logic. Stored blocks counted is increased in `SetBlockBatch` and decreased in two scenarios: a) Once block is proposed and removed from the storage - in `BlockStorage.SetBlockAsProposed(...)` method; b) During state reset process when `BlockStorage` is fully or partially purged;
Previous commit introduces capacity limit for the `BlockStorage`. This commit contains improvements of `Aggregator` to handle new `ErrCapacityLimitReached` error. The core changes in behaviour are defined in the `Test_Block_Storage_Capacity_Exceeded` test. It's expected that, in case if capacity limit is reached, new generated batches are not handled by `Aggregator`: 1. No new tasks are created; 2. Latest fetched values are not updated;
zadykian
force-pushed
the
sc/fix/storage-capacity-limit
branch
from
347bbad to
98fad98
Compare
akokoshn
approved these changes
Mar 4, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sync Committee: BlockStorage Capacity Limit
In case if number of blocks stored in the
BlockStorageincreases a certain amount, state reset process failed due toviolation of Badger transaction size limit:
Txn is too big to fit into one requestWe need to prevent Sync Committee storage from growing indefinitely in case the prover network is down or unresponsive by introducing a capacity limit for the storage:
Introduced a configurable capacity limit for
BlockStoragewith default settings and validation logic. Stored blocks counted is increased inSetBlockBatchand decreased in two scenarios:a) Once block is proposed and removed from the storage - in
BlockStorage.SetBlockAsProposed(...)method;b) During state reset process when
BlockStorageis fully or partially purged;Improved
Aggregatorto handle newErrCapacityLimitReachederror. The core changes in behavior are defined in theTest_Block_Storage_Capacity_Exceededtest.It is expected that if the capacity limit is reached, newly generated batches are not handled by
Aggregator: