make syncer permanent #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olegrok
force-pushed
the
permanent-syncer
branch
from
056307e to
0d11644
Compare
olegrok
force-pushed
the
permanent-syncer
branch
from
0d11644 to
7ccd1e9
Compare
olegrok
force-pushed
the
permanent-syncer
branch
from
7ccd1e9 to
92b2b94
Compare
olegrok
force-pushed
the
permanent-syncer
branch
from
92b2b94 to
2f11a64
Compare
olegrok
force-pushed
the
permanent-syncer
branch
from
2f11a64 to
07860a7
Compare
olegrok
force-pushed
the
permanent-syncer
branch
from
07860a7 to
209d9d1
Compare
olegrok
force-pushed
the
permanent-syncer
branch
from
209d9d1 to
ce3e3e2
Compare
olegrok
force-pushed
the
permanent-syncer
branch
from
ce3e3e2 to
485fc9e
Compare
olegrok
force-pushed
the
permanent-syncer
branch
from
485fc9e to
adcc746
Compare
olegrok
force-pushed
the
permanent-syncer
branch
from
adcc746 to
0104e3c
Compare
olegrok
force-pushed
the
permanent-syncer
branch
from
0104e3c to
d3da09b
Compare
In case of several validators it should be able to be in-sync. So we need to create syncer even for active shards.
Syncer works at the same time with consensus and block generation. So it's possible that we get new blocks via a network that was previously committed via consensus. In future we can cache it somehow but it should be done in separate module that keeps fresh blockchain state.
olegrok
force-pushed
the
permanent-syncer
branch
from
d3da09b to
e005621
Compare
Zerg1996
approved these changes
Feb 2, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case of several validators it should be able to be in-sync. So we need to create syncer even for active shards.
Closes #109