-
Notifications
You must be signed in to change notification settings - Fork 18
[Bounty] Headless browser module #40 #47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
Amazing contribution!
Looks like you hard-coded a path into this code (?) |
Oh, got it, you've prepared this file in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good enough. Only some trivial things to mention.
amended - removed generated native configs (only needed for binary generation), updated go wrapper, split script docker into arm and amd versions
New Files/Folders
ResourcesExciting Performance Improvements (specifically for static strategies; fallback/webdriver remain unchanged)6 request batched using static strategy (same as OP) but using native binary 1.04s
|
typo should be cljc not clj
Why Babashka (Clojure)?
Design
HTTP API
CLI API (for individual find):
bb src/finder.clj
-url --url string required
-matcher --matcher string required (css/js/regex/xpath expression)
-match-by --match-by string required (choose one ["css" "js" "regex" "xpath" ])
-secret --secret string
-timeout --timeout unit
-strategy --strategy string required (choose one ["fallback" "static" "webdriver"])
CLI API (for server process):
bb src/finder.clj
-server --server true
-port --port uint (default: 8080)
-address --address string (default 0.0.0.0)
Strategies
25%slower compared to static regex/cssPerformance example and demo
HTTP Batching
6 requests using fallback strategy processed in parallel ~4secs
6 requests using static strategy processed in parallel ~3secs
Currently WIP