Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: DecompositionSeries BandsTable should be typed #2044

Open
3 tasks done
mavaylon1 opened this issue Feb 27, 2025 · 1 comment
Open
3 tasks done

[Feature]: DecompositionSeries BandsTable should be typed #2044

mavaylon1 opened this issue Feb 27, 2025 · 1 comment
Assignees
Labels
category: enhancement improvements of code or code behavior priority: high impacts proper operation or use of feature important to most users

Comments

@mavaylon1
Copy link
Collaborator

What would you like to see added to PyNWB?

From making columns in DynamicTable expandable by default, the edge case of "named but untyped" types blocks full support of that feature. The current known types are ElectrodesTable and the bands table in DecompositionSeries. The reason this is an issue is that the shape definition is not being used from the untyped type but from the schema of DynamicTable.

Bands Table:
The schema defines the shape to be [None, 2]. We want the shape so that we don't override schema set values when making things expandable. In this case, We want the shape of the dataset to be written as [None, 2] and not [None, None], i.e., not expandable in dimensions that are defined not to be.

The fix is to create a type for Bands Table.

Is your feature request related to a problem?

Above

What solution would you like?

Above.

Do you have any interest in helping implement the feature?

Yes.

Code of Conduct

@mavaylon1 mavaylon1 self-assigned this Feb 27, 2025
@mavaylon1 mavaylon1 added category: enhancement improvements of code or code behavior priority: high impacts proper operation or use of feature important to most users labels Feb 27, 2025
@mavaylon1
Copy link
Collaborator Author

hdmf-dev/hdmf#1180

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: enhancement improvements of code or code behavior priority: high impacts proper operation or use of feature important to most users
Projects
None yet
Development

No branches or pull requests

1 participant