Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow nwbinspector CLI to accept URLs #559

Merged
merged 4 commits into from
Feb 20, 2025
Merged

Allow nwbinspector CLI to accept URLs #559

merged 4 commits into from
Feb 20, 2025

Conversation

stephprince
Copy link
Contributor

Motivation

Fix #558.

Add a condition to distinguish dandiset file paths and URLs, and add a test for using a URL with the CLI

@stephprince stephprince requested a review from rly February 20, 2025 18:27
@rly
Copy link
Contributor

rly commented Feb 20, 2025

Should the test be added into tests/streaming_cli_tests.py instead of tests/streaming_tests.py

@stephprince
Copy link
Contributor Author

Should the test be added into tests/streaming_cli_tests.py instead of tests/streaming_tests.py

Good point, yes that makes more sense - I've moved it there.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.90%. Comparing base (6bd898c) to head (e6f99ff).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #559      +/-   ##
==========================================
+ Coverage   82.73%   86.90%   +4.16%     
==========================================
  Files          47       47              
  Lines        1512     1512              
==========================================
+ Hits         1251     1314      +63     
+ Misses        261      198      -63     
Files with missing lines Coverage Δ
src/nwbinspector/_nwbinspector_cli.py 92.00% <100.00%> (+8.00%) ⬆️

... and 4 files with indirect coverage changes

@stephprince stephprince merged commit 53e283d into dev Feb 20, 2025
40 checks passed
@stephprince stephprince deleted the fix-inspect-url branch February 20, 2025 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: nwbinspector CLI fails when url is provided
3 participants