Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional url resolver needed by dendro #94

Merged
merged 3 commits into from
Sep 17, 2024
Merged

Conversation

magland
Copy link
Collaborator

@magland magland commented Sep 10, 2024

Need to add arbitrary additional url resolvers for DANDI auth. It's a particularly special case for dendro because the DANDI API is not exposed to the job runner - so the resolution happens via an API request to dendro.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 39.97683% with 518 lines in your changes missing coverage. Please review.

Project coverage is 69.13%. Comparing base (ff05704) to head (3b397f3).

Files with missing lines Patch % Lines
lindi/tar/lindi_tar.py 10.49% 273 Missing ⚠️
lindi/LindiH5pyFile/LindiH5pyFile.py 54.33% 79 Missing ⚠️
lindi/tar/create_tar_header.py 3.70% 52 Missing ⚠️
...ndi/LindiH5pyFile/LindiReferenceFileSystemStore.py 58.77% 47 Missing ⚠️
lindi/tar/LindiTarStore.py 29.82% 40 Missing ⚠️
lindi/LindiH5ZarrStore/LindiH5ZarrStore.py 85.03% 19 Missing ⚠️
...ndi/conversion/create_zarr_dataset_from_h5_data.py 81.25% 3 Missing ⚠️
...indi/LindiH5pyFile/writers/LindiH5pyGroupWriter.py 0.00% 2 Missing ⚠️
lindi/LindiH5ZarrStore/_util.py 75.00% 1 Missing ⚠️
lindi/LindiRemfile/LindiRemfile.py 66.66% 1 Missing ⚠️
... and 1 more
Additional details and impacted files
@@             Coverage Diff             @@
##             main      #94       +/-   ##
===========================================
- Coverage   79.47%   69.13%   -10.34%     
===========================================
  Files          30       34        +4     
  Lines        2265     3042      +777     
===========================================
+ Hits         1800     2103      +303     
- Misses        465      939      +474     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rly
Copy link
Contributor

rly commented Sep 17, 2024

Looks good. We will create a separate issue to move the embedded dandi api resolver to live in this global dictionary.

@magland magland merged commit 66c36d5 into main Sep 17, 2024
6 checks passed
@magland magland deleted the additional-url-resolver branch September 17, 2024 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants