Merge pull request #4731 from jmcrawford45/PS-5576

Fix plugins list endpoint
Netflix · Dec 5, 2023 · 565b61c · 565b61c
2 parents ce352c5 + 153e2ab
commit 565b61c
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 2 deletions.
diff --git a/lemur/plugins/lemur_vault_dest/plugin.py b/lemur/plugins/lemur_vault_dest/plugin.py
@@ -39,7 +39,7 @@ class VaultSourcePlugin(SourcePlugin):
             "name": "vaultUrl",
             "type": "str",
             "required": True,
-            "validation": URL_RE,
+            "validation": URL_RE.pattern,
             "helpMessage": "Valid URL to Hashi Vault instance",
         },
         {
@@ -166,7 +166,7 @@ class VaultDestinationPlugin(DestinationPlugin):
             "name": "vaultUrl",
             "type": "str",
             "required": True,
-            "validation": URL_RE,
+            "validation": URL_RE.pattern,
             "helpMessage": "Valid URL to Hashi Vault instance",
         },
         {

diff --git a/lemur/tests/test_plugins.py b/lemur/tests/test_plugins.py
@@ -0,0 +1,20 @@
+from lemur.plugins.views import *  # noqa
+
+
+from .vectors import (
+    VALID_ADMIN_HEADER_TOKEN,
+)
+
+
+def test_plugins_list_get(client, app):
+    response = client.get(api.url_for(PluginsList), headers=VALID_ADMIN_HEADER_TOKEN)
+    assert response.status_code == 200
+
+    data = response.get_json()
+
+    # Perform some assertions on data based on what you expect
+    assert 'items' in data
+    assert isinstance(data['items'], list)
+
+    for item in data['items']:
+        assert 'title' in item