Simplified Item and Inventory "Remove" function as well as removed non-functional code

[DoopieWop]

Both functions use a loop to remove the item. As far as I can tell this really isn't necessary. In both cases I simply use the item's gridX and gridY member values to find their entry in the Inventory "slots" table to delete them there.

In Item "Remove" function, there is code that would be run when the loop couldn't find the item in the Inventory "slots" table. I've personally never had this happen, additionally the code that is supposed to run, if the loop doesn't find the item, doesn't make sense to me.

First, the Inventory "slots" table (the table that stores its items, with their grid X and Y values as the keys) is emptied.

helix/gamemode/core/meta/sh_item.lua

Line 439 in 418947a

inv.slots = {}

Next. a loop using the Inventory "Iter" function is supposed to loop through all the items stored in the inventory, then populate the "slots" table (but only within the x, y and width & height values of the to-be-removed item?) with the adequate data. However because "Iter" internally uses the "slots" table (which at this point is empty) effectively nothing happens.

helix/gamemode/core/meta/sh_item.lua

Lines 440 to 448 in 418947a

	for k, _ in inv:Iter() do
	if (k.invID == inv:GetID()) then
	for x = self.gridX, self.gridX + (self.width - 1) do
	for y = self.gridY, self.gridY + (self.height - 1) do
	inv.slots[x][y] = k.id
	end
	end
	end
	end

Lastly the changed inventory is meant to be synced to the inventory owner, however the if-condition expects a player object, while the inventory member value "owner" actually returns a character ID (or in general a number, for instance for container inventories), so this if-condition actually causes an error, if it were to be executed.

helix/gamemode/core/meta/sh_item.lua

Lines 450 to 452 in 418947a

	if (IsValid(inv.owner) and inv.owner:IsPlayer()) then
	inv:Sync(inv.owner, true)
	end

To me this appears to be outdated code, leftover from the transition from Nutscript to Helix, so I'd just remove it.

[alexgrist]

Next. a loop using the Inventory "Iter" function is supposed to loop through all the items stored in the inventory, then populate the "slots" table (but only within the x, y and width & height values of the to-be-removed item?) with the adequate data. However because "Iter" internally uses the "slots" table (which at this point is empty) effectively nothing happens.

This is due to #468 which removed some usages of GetItems() including in the META:Remove function.

helix/gamemode/core/meta/sh_item.lua

Lines 438 to 442 in 4e49199

	if (failed) then
	local items = inv:GetItems()
	inv.slots = {}
	for _, v in pairs(items) do

The items table is likely a cache of the items prior to the slots being cleared which is looped.

[DoopieWop]

I misunderstood the way items are stored in the inventory slots table, my changed remove functions would not work with items larger than 1x1