Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added message field for solana transfers #224

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

frolvanya
Copy link
Contributor

@frolvanya frolvanya commented Feb 3, 2025

This PR should be merged only when new version of contract on solana will be deployed

@frolvanya frolvanya requested review from karim-en and kiseln February 3, 2025 19:50
@karim-en
Copy link
Collaborator

karim-en commented Feb 3, 2025

@frolvanya Do we need to update the indexers for this?
CC @attila0x2A

@frolvanya
Copy link
Contributor Author

frolvanya commented Feb 3, 2025

@karim-en
Copy link
Collaborator

karim-en commented Feb 3, 2025

@karim-en yes, message field must be added here: https://github.com/Near-One/bridge-indexer-rs/blob/b49669a5a7c17f72e68ee4f125ea7375d0c8559a/solana-indexer/src/parser.rs#L28

But we should be able to parse both versions of the payloads, can we add a fallback to try to deserialize with the old format if the new one fails ?

@frolvanya
Copy link
Contributor Author

@karim-en hmm, we can make message field optional. But why do we need to be able to parse both versions? All older tx are processed

@karim-en
Copy link
Collaborator

karim-en commented Feb 3, 2025

@karim-en hmm, we can make message field optional. But why do we need to be able to parse both versions? All older tx are processed

It is ok for the relayer, but the indexer should be able to process both kind of messages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants