feat: implement NEAR token factory #104
Conversation
evm/bridge-token-factory/contracts/BridgeTokenFactoryWormhole.sol
Outdated
Show resolved
Hide resolved
near/nep141-locker/src/lib.rs
Outdated
| amount_to_transfer, | ||
| (!transfer_message.msg.is_empty()) | ||
| .then(|| transfer_message.msg.clone()), | ||
| ) |
There was a problem hiding this comment.
Now, I don’t like that we call ft_transfer_call without handling errors… And we only provide 50 TGas, which isn’t much. It could just return an error due to an out-of-gas issue or because some inner account doesn’t have storage. But in this case, the transaction will already be finalized.
| address.is_zero() | ||
| } | ||
| OmniAddress::Near(address) => address.len() == 0, | ||
| OmniAddress::Sol(address) => address.is_zero(), |
There was a problem hiding this comment.
Just making note that since we're using Wrapped SOL we wouldn't have a zero address
There was a problem hiding this comment.
Deploy native token has been added here
ac3979a
| if self.deployed_tokens.contains(&token_id) { | ||
| ext_token::ext(token_id.clone()) | ||
| .with_static_gas(BURN_TOKEN_GAS) | ||
| .burn(amount); |
There was a problem hiding this comment.
My original understanding was that we burn tokens only when withdrawing to the original chain, otherwise we lock them just like near-native tokens. Would that be simpler or not?
There was a problem hiding this comment.
I think if we are transferring from ETH to SOL an erc20 token, then we should consider it as a direct transfer, and the NEAR protocol is used just as a mediator for this transfer.
Also it will be hard to track the total supply in this case, because for now the locked amount should equal to the sum of all total supplies on other chains.
Can you please clarify |
The PR implement the NEAR token factory to bridge the none-NEAR first tokens to Near and other chains.