Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added basic lights (directional, point, spot) #806

Merged
merged 34 commits into from
Nov 19, 2024
Merged

Added basic lights (directional, point, spot) #806

merged 34 commits into from
Nov 19, 2024

Conversation

jaremieromer
Copy link
Member

No description provided.

McCallisterRomer and others added 30 commits November 8, 2024 16:36
@McCallisterRomer
initial system
abb8155
@McCallisterRomer
some adjustments
eafe412
@jaremieromer
Initial commit
b8bf4ce
@jaremieromer
Removed deps
4035d0f
@jaremieromer
Cleanup
ecac6ba
@McCallisterRomer
update buffer + cutover mesh renderer resource
d1708c9
@McCallisterRomer
remove debug-based validation test
2ff3a02
@McCallisterRomer
code review
35aa32e
@jaremieromer
Cleaned up the resources in ShaderBindings
64fd59a
@jaremieromer
issue removal
e4c80f7
@jaremieromer
Merge branch 'vnext' of https://github.com/NcStudios/NcEngine into ja…
3e07a96 
…re-resource-clarity
@jaremieromer
Initial commit. Added DirectionalLight component. Fleshed out GPU sid…
0d4508c 
…e stuff.
@McCallisterRomer
Merge branch 'vnext' of https://github.com/NcStudios/NcEngine into ca…
10f98f0 
…l/material_pass_system
@McCallisterRomer
fix test include
d70ba06
@McCallisterRomer
finish plumbing + tests
4560870
@McCallisterRomer
clean up
51f4b87
@McCallisterRomer
more tests + reorganize
4f971cd
@McCallisterRomer
more cleanup
0d90227
@jaremieromer
Merge branch 'cal/material_pass_system' of https://github.com/NcStudi…
aa7f1b5 
…os/NcEngine into jare-lights
@jaremieromer
Started adding lighting subsystem
c01cd7d
@jaremieromer
Merge branch 'vnext' of https://github.com/NcStudios/NcEngine into ja…
495fd24 
…re-lights
@jaremieromer
Comparing against vNext
195782f
@jaremieromer
Merge branch 'vnext' of https://github.com/NcStudios/NcEngine into ja…
0a008ed 
…re-lights
@jaremieromer
Time for shaders now
033f4a6
@jaremieromer
Just need to add lighting influence in shader
d32db6d
@jaremieromer
Merge branch 'vnext' of https://github.com/NcStudios/NcEngine into ja…
00706b8 
…re-lights
@jaremieromer
Point Light wired up in shader
e050b12
@jaremieromer
In progress - partial phong lighting implemented in point light, Band…
539c940 
…ing issue present
@jaremieromer
Basic lighting implemented
d5f42b0
@jaremieromer
All lights wired up
1339d4c
McCallisterRomer
McCallisterRomer reviewed Nov 18, 2024
View reviewed changes
Copy link
Member

@McCallisterRomer McCallisterRomer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, didn't see it was a draft until now. I'll post my comments, but can rereview if you have more to do here.

source/ncengine/graphics2/diligent/ShaderFactory.h Show resolved Hide resolved
source/ncengine/graphics2/diligent/resource/GlobalEnvironmentResource.h Outdated Show resolved Hide resolved
source/ncengine/graphics2/diligent/resource/base/StructuredBuffer.h Outdated Show resolved Hide resolved
source/ncengine/graphics2/diligent/resource/component/ComponentResourceSignature.h Outdated Show resolved Hide resolved
source/ncengine/graphics2/frontend/GraphicsFrontend.cpp Outdated Show resolved Hide resolved
source/ncengine/graphics2/frontend/subsystem/CameraRenderState.h Outdated Show resolved Hide resolved
source/ncengine/graphics2/frontend/subsystem/LightSubsystem.h Outdated Show resolved Hide resolved
source/ncengine/graphics2/frontend/subsystem/LightSubsystem.h Outdated Show resolved Hide resolved
source/ncengine/ui/editor/impl/ComponentWidgets.cpp Show resolved Hide resolved
test/ncengine/serialize/ComponentSerialization_integration_tests.cpp Outdated Show resolved Hide resolved
@jaremieromer jaremieromer marked this pull request as ready for review November 18, 2024 22:37
@jaremieromer jaremieromer merged commit e3cc906 into vnext Nov 19, 2024
10 checks passed
@jaremieromer jaremieromer deleted the jare-lights branch November 19, 2024 00:30
@jaremieromer jaremieromer restored the jare-lights branch November 22, 2024 02:47
@McCallisterRomer McCallisterRomer deleted the jare-lights branch November 24, 2024 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@McCallisterRomer McCallisterRomer McCallisterRomer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jaremieromer @McCallisterRomer