Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove AmbientColor from PointLight and move to Environment #807

Open
jaremieromer opened this issue Nov 18, 2024 · 1 comment
Open

Remove AmbientColor from PointLight and move to Environment #807

jaremieromer opened this issue Nov 18, 2024 · 1 comment

Comments

@jaremieromer
Copy link
Member

Point lights shouldn't have an ambient color, that should be driven by a scene-constant.
Remove AmbientColor from PointLightData and the editor interface for point lights and add it to GlobalEnvironmentData

@McCallisterRomer
Copy link
Member

We also shouldn't need to add/remove callbacks on light components anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants