Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SCC-4408 - Standardize server-side error logging #453

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

SCC-4408 - Standardize server-side error logging #453

wants to merge 10 commits into from
+55 −33

Conversation

dgcohen
Copy link
Contributor

@dgcohen dgcohen commented Jan 21, 2025 •
edited
Loading

Ticket:

This PR does the following:

  • Added logServerError utility function to standardize CloudWatch logging. This function accepts two parameters:
    • The function or file name where the call was made
    • The error message
  • Updated Next.js config to prevent Webpack from polyfilling fs (a dependency of Winston) in client builds. This avoids errors when importing server-side functions that use Winston in getServerSideProps.

How has this been tested?

  • NA

Accessibility concerns or updates

  • NA

Checklist:

  • I updated the CHANGELOG with the appropriate information and JIRA ticket number (if applicable).
  • I have added relevant accessibility documentation for this pull request.
  • All new and existing tests passed.

@vercel Vercel
Copy link

vercel bot commented Jan 21, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
research-catalog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 12, 2025 3:32pm

@dgcohen dgcohen changed the title SCC-4408 - Clean up error logs SCC-4408 - Standardize server-side error logging Feb 12, 2025
@dgcohen dgcohen marked this pull request as ready for review February 12, 2025 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EdwinGuzman EdwinGuzman Awaiting requested review from EdwinGuzman

@charmingduchess charmingduchess Awaiting requested review from charmingduchess

@7emansell 7emansell Awaiting requested review from 7emansell

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dgcohen