Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable support of GetJsonObject in Qualification tool #737

Merged
merged 1 commit into from
Jan 23, 2024
Merged

Disable support of GetJsonObject in Qualification tool #737

merged 1 commit into from
Jan 23, 2024

Conversation

amahussein
Copy link
Collaborator

Fixes #731

  • This PR disables the support of getJsonObject by marking the the op as NS in the supportedExprs.csv
  • Adds unit test to verify that the GetJsonObject will cause projectExec to fall back.

@amahussein
Disable support of GetJsonObject in Qualification tool
2ef4e2a 
Signed-off-by: Ahmed Hussein (amahussein) <a@ahussein.me>
@amahussein amahussein added bug Something isn't working core_tools Scope the core module (scala) labels Jan 23, 2024
@amahussein amahussein self-assigned this Jan 23, 2024
@amahussein amahussein requested a review from nartal1 January 23, 2024 04:45
@amahussein
Copy link
Collaborator Author

Error is unrelated to the code change.

parthosa
parthosa approved these changes Jan 23, 2024
View reviewed changes
Copy link
Collaborator

@parthosa parthosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @amahussein.

@amahussein amahussein merged commit d69dab8 into NVIDIA:dev Jan 23, 2024
14 checks passed
@amahussein amahussein deleted the spark-rapids-tools-731 branch January 23, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@parthosa parthosa parthosa approved these changes

@nartal1 nartal1 Awaiting requested review from nartal1

Assignees

@amahussein amahussein

Labels
bug Something isn't working core_tools Scope the core module (scala)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Disable support of GetJsonObject in Qualification tool
2 participants
@amahussein @parthosa