Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add comment for each expected_raw_feature indicating CSV source #1547

Merged
merged 1 commit into from
Feb 19, 2025

Conversation

leewyang
Copy link
Collaborator

This PR adds a comment for each feature in the qualx expected_raw_features list, which indicates:

  • the source CSV file produced by the Profiler tool
  • the source column name in parentheses if different than the feature name, e.g. _mean features derived from _sum features.
  • "N/A", if the feature is derived from other features (or other information outside of the CSV files, e.g. scaleFactor).

The hope is that this list (and the comments) can be maintained as the features evolve.

Signed-off-by: Lee Yang <leewyang@gmail.com>
@leewyang leewyang self-assigned this Feb 18, 2025
@leewyang leewyang added the user_tools Scope the wrapper module running CSP, QualX, and reports (python) label Feb 18, 2025
Copy link
Collaborator

@amahussein amahussein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @leewyang
This is very useful indeed!

@amahussein amahussein merged commit ba84588 into NVIDIA:dev Feb 19, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
user_tools Scope the wrapper module running CSP, QualX, and reports (python)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants