Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA] Core tools can capture stdout and errors into log files #735

Closed
Tracked by #1038
amahussein opened this issue Jan 22, 2024 · 0 comments · Fixed by #1269
Closed
Tracked by #1038

[FEA] Core tools can capture stdout and errors into log files #735

amahussein opened this issue Jan 22, 2024 · 0 comments · Fixed by #1269
Assignees
Labels
core_tools Scope the core module (scala) feature request New feature or request usability track issues related to the Tools's user experience

Comments

@amahussein
Copy link
Collaborator

amahussein commented Jan 22, 2024

Is your feature request related to a problem? Please describe.

It will be helpful if the STDOUT of the tools is kept in a log. This will be helpful troubleshooting the output.
For example, we can take a look at the exception-errors/warning messages.

Otherwise, we lose some good information by not keeping the runtime log information as part of the output

Approach:

  1. Create a temporary log4j properties file with updated path to store the logs (It's usually rapids_output_folder)
  2. Use the new log4j properties file in java command.

Challenges:

  • Ideally the log-file should be within the output-directory of the run. This means that we should create the output directory before we start processing the eventlogs. Also, we still need to consider the case when the tools fail to create an output-directory
  • Take into Consideration CI/CD tests and how the output will be verified.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core_tools Scope the core module (scala) feature request New feature or request usability track issues related to the Tools's user experience
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants