Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA] AutoTuner should not skip non-gpu eventlogs #726

Closed
Tracked by #700
amahussein opened this issue Jan 16, 2024 · 0 comments · Fixed by #728
Closed
Tracked by #700

[FEA] AutoTuner should not skip non-gpu eventlogs #726

amahussein opened this issue Jan 16, 2024 · 0 comments · Fixed by #728
Assignees
@amahussein
Labels
core_tools Scope the core module (scala) feature request New feature or request

Comments

@amahussein
Copy link
Collaborator

Is your feature request related to a problem? Please describe.

Currently, given eventlogs with RAPIDS-plugin disabled, the Autotuner will not run any recommendations displaying a message that it requires GPU eventlog.

We need to change that behavior so that the Autotuner can still make recommendations.
@amahussein amahussein added feature request New feature or request ? - Needs Triage core_tools Scope the core module (scala) labels Jan 16, 2024
@amahussein amahussein self-assigned this Jan 16, 2024
@amahussein amahussein mentioned this issue Jan 16, 2024
Closed
amahussein added a commit to amahussein/spark-rapids-tools that referenced this issue Jan 16, 2024
@amahussein
[FEA] AutoTuner should not skip non-gpu eventlogs
06457dc 
Signed-off-by: Ahmed Hussein (amahussein) <a@ahussein.me>

Fixes NVIDIA#726

- The Autotuner can still make recommendation regardless of the GPU
  profile info
- Changed the code to avoid Null objects. The Autotuner could throw a
  NPE when the user not supplying any eventlog.
- Fixed the unit-tests accordingly
- Tested the new changes running a CPU eventlog
This was referenced Jan 16, 2024
Merged
Closed
amahussein added a commit that referenced this issue Jan 18, 2024
@amahussein
[FEA] AutoTuner should not skip non-gpu eventlogs (#728)
2f1c7ee 
* [FEA] AutoTuner should not skip non-gpu eventlogs

Fixes #726

- The Autotuner can still make recommendation regardless of the GPU
  profile info
- Changed the code to avoid Null objects. The Autotuner could throw a
  NPE when the user not supplying any eventlog.
- Fixed the unit-tests accordingly
- Tested the new changes running a CPU eventlog

---------

Signed-off-by: Ahmed Hussein (amahussein) <a@ahussein.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@amahussein amahussein

Labels
core_tools Scope the core module (scala) feature request New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[FEA] AutoTuner should not skip non-gpu eventlogs amahussein/spark-rapids-tools
1 participant
@amahussein