Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA] Support to_utc_timestamp expression #721

Closed
amahussein opened this issue Jan 9, 2024 · 0 comments · Fixed by #796
Closed

[FEA] Support to_utc_timestamp expression #721

amahussein opened this issue Jan 9, 2024 · 0 comments · Fixed by #796
Assignees
@amahussein
Labels
audit_plugin Audit related tasks for RAPIDS plugin changes core_tools Scope the core module (scala) feature request New feature or request

Comments

@amahussein
Copy link
Collaborator

amahussein commented Jan 9, 2024 •
edited
Loading

Is your feature request related to a problem? Please describe.

Following the splugin support to to_utc_timestamp, we need to add that to the supported expressions as well.
NVIDIA/spark-rapids#10144

--- temp/spark-rapids-tools/core/src/main/resources/supportedExprs.csv	2024-01-09 13:01:45.388998564 +0000
+++ temp/spark-rapids/tools/generated_files/supportedExprs.csv	2024-01-09 13:01:43.096998698 +0000
@@ -576,0 +579,3 @@
+ToUTCTimestamp,S,`to_utc_timestamp`,None,project,timestamp,NA,NA,NA,NA,NA,NA,NA,NA,PS,NA,NA,NA,NA,NA,NA,NA,NA,NA
+ToUTCTimestamp,S,`to_utc_timestamp`,None,project,timezone,NA,NA,NA,NA,NA,NA,NA,NA,NA,PS,NA,NA,NA,NA,NA,NA,NA,NA
+ToUTCTimestamp,S,`to_utc_timestamp`,None,project,result,NA,NA,NA,NA,NA,NA,NA,NA,PS,NA,NA,NA,NA,NA,NA,NA,NA,NA

Additional Context

NVIDIA/spark-rapids#10223
@amahussein amahussein added feature request New feature or request ? - Needs Triage core_tools Scope the core module (scala) audit_plugin Audit related tasks for RAPIDS plugin changes and removed ? - Needs Triage labels Jan 9, 2024
@amahussein amahussein self-assigned this Feb 21, 2024
amahussein added a commit to amahussein/spark-rapids-tools that referenced this issue Feb 21, 2024
@amahussein
Sync up supported ops for 24.02 plugin release
e2ac6f6 
Signed-off-by: Ahmed Hussein (amahussein) <a@ahussein.me>

Fixes NVIDIA#795, Fixes NVIDIA#721, Fixes NVIDIA#712

This code change is to sync the supported-ops in the tools with the
Plugin release 24.02.0
@amahussein amahussein mentioned this issue Feb 21, 2024
Merged
amahussein added a commit to amahussein/spark-rapids-tools that referenced this issue Feb 22, 2024
@amahussein
Sync up supported ops for 24.02 plugin release
0f3be9d 
Signed-off-by: Ahmed Hussein (amahussein) <a@ahussein.me>

Fixes NVIDIA#795, Fixes NVIDIA#721, Fixes NVIDIA#712

This code change is to sync the supported-ops in the tools with the
Plugin release 24.02.0 in addition to disabling `JsonTuple`
amahussein added a commit that referenced this issue Feb 22, 2024
@amahussein
Sync up supported ops for 24.02 plugin release (#796)
1b83318 
* Sync up supported ops for 24.02 plugin release

Fixes #795, Fixes #721, Fixes #712

- This code change is to sync the supported-ops in the tools with the
Plugin release 24.02.0 in addition to disabling `JsonTuple`
- Disable unit-tests that checks that json_tuple is supported

---------

Signed-off-by: Ahmed Hussein (amahussein) <a@ahussein.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@amahussein amahussein

Labels
audit_plugin Audit related tasks for RAPIDS plugin changes core_tools Scope the core module (scala) feature request New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Sync up supported ops for 24.02 plugin release amahussein/spark-rapids-tools
1 participant
@amahussein