Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Qual tool - AdaptiveSparkPlan should not show up as unsupported operator #1555

Open
tgravescs opened this issue Feb 20, 2025 · 2 comments
Assignees
Labels
bug Something isn't working core_tools Scope the core module (scala)

Comments

@tgravescs
Copy link
Collaborator

Describe the bug
I saw a user running the Qualification tool on a very small app and it came back as not recommended. They were looking at why it wasn't recommended and saw the AdaptiveQueryexec in the unsupported operators and were confused by this.

We should not be putting this into the unsupported operators or we should somehow make it clear to the user it doesn't matter.

@tgravescs tgravescs added ? - Needs Triage bug Something isn't working labels Feb 20, 2025
@amahussein amahussein added the core_tools Scope the core module (scala) label Feb 21, 2025
@amahussein amahussein self-assigned this Feb 21, 2025
@amahussein
Copy link
Collaborator

amahussein commented Feb 21, 2025

Discussed offline to get more details.
this is regarding rapids_4_spark_qualification_output_unsupportedOperators.csv. It shows all the execs along with other columns such as Action. So Unsupported + ignoreNoPerf should be ignored columns.
The point here that the user does not necessarily understand what those actions mean.

We might need to consider one or all of the following roadmaps:

  • provide a separate view to the user. Filtered out and cleaned from all those details.
  • remove those rows like ColumnarToRow, AdaptiveSparkPlan ..etc.

CC: @viadea

@amahussein amahussein changed the title [BUG] Qual tool - AdaptiveQueryExec should not show up as unsupported operator [BUG] Qual tool - AdaptiveSparkPlan should not show up as unsupported operator Feb 21, 2025
@amahussein
Copy link
Collaborator

CC: @leewyang and @eordentlich Do you have any thoughts about how do we want to report this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working core_tools Scope the core module (scala)
Projects
None yet
Development

No branches or pull requests

3 participants