Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop deprecated iterators from Thrust cuda utils #3905

Merged

Conversation

bernhardmgruber
Copy link
Contributor

No description provided.

@bernhardmgruber bernhardmgruber requested a review from a team as a code owner February 21, 2025 21:09
@bernhardmgruber bernhardmgruber added thrust For all items related to Thrust. breaking Breaking change labels Feb 21, 2025
@bernhardmgruber bernhardmgruber enabled auto-merge (squash) February 21, 2025 21:59
Copy link
Contributor

🟩 CI finished in 1h 38m: Pass: 100%/93 | Total: 2d 13h | Avg: 39m 43s | Max: 1h 24m | Hits: 73%/133745
  • 🟩 cub: Pass: 100%/45 | Total: 1d 15h | Avg: 52m 27s | Max: 1h 24m | Hits: 67%/53305

    🟩 cpu
      🟩 amd64              Pass: 100%/43  | Total:  1d 13h | Avg: 52m 09s | Max:  1h 24m | Hits:  67%/50883 
      🟩 arm64              Pass: 100%/2   | Total:  1h 57m | Avg: 58m 37s | Max:  1h 00m | Hits:  64%/2422  
    🟩 ctk
      🟩 12.0               Pass: 100%/5   | Total:  4h 52m | Avg: 58m 24s | Max:  1h 04m | Hits:  55%/5888  
      🟩 12.5               Pass: 100%/2   | Total:  2h 11m | Avg:  1h 05m | Max:  1h 05m | Hits:  64%/2240  
      🟩 12.8               Pass: 100%/38  | Total:  1d 08h | Avg: 50m 58s | Max:  1h 24m | Hits:  68%/45177 
    🟩 cudacxx
      🟩 ClangCUDA18        Pass: 100%/2   | Total:  1h 58m | Avg: 59m 03s | Max: 59m 31s | Hits:  70%/2092  
      🟩 nvcc12.0           Pass: 100%/5   | Total:  4h 52m | Avg: 58m 24s | Max:  1h 04m | Hits:  55%/5888  
      🟩 nvcc12.5           Pass: 100%/2   | Total:  2h 11m | Avg:  1h 05m | Max:  1h 05m | Hits:  64%/2240  
      🟩 nvcc12.8           Pass: 100%/36  | Total:  1d 06h | Avg: 50m 32s | Max:  1h 24m | Hits:  68%/43085 
    🟩 cudacxx_family
      🟩 ClangCUDA          Pass: 100%/2   | Total:  1h 58m | Avg: 59m 03s | Max: 59m 31s | Hits:  70%/2092  
      🟩 nvcc               Pass: 100%/43  | Total:  1d 13h | Avg: 52m 08s | Max:  1h 24m | Hits:  67%/51213 
    🟩 cxx
      🟩 Clang14            Pass: 100%/4   | Total:  3h 45m | Avg: 56m 20s | Max: 57m 50s | Hits:  64%/4852  
      🟩 Clang15            Pass: 100%/2   | Total:  1h 56m | Avg: 58m 14s | Max: 58m 53s | Hits:  64%/2422  
      🟩 Clang16            Pass: 100%/2   | Total:  1h 52m | Avg: 56m 26s | Max: 58m 02s | Hits:  64%/2422  
      🟩 Clang17            Pass: 100%/2   | Total:  1h 48m | Avg: 54m 22s | Max: 54m 37s | Hits:  64%/2422  
      🟩 Clang18            Pass: 100%/7   | Total:  5h 30m | Avg: 47m 12s | Max: 59m 31s | Hits:  76%/8147  
      🟩 GCC7               Pass: 100%/2   | Total:  1h 55m | Avg: 57m 50s | Max: 58m 33s | Hits:  64%/2426  
      🟩 GCC8               Pass: 100%/1   | Total: 57m 05s | Avg: 57m 05s | Max: 57m 05s | Hits:  64%/1213  
      🟩 GCC9               Pass: 100%/2   | Total:  1h 54m | Avg: 57m 07s | Max: 58m 47s | Hits:  64%/2426  
      🟩 GCC10              Pass: 100%/2   | Total:  1h 53m | Avg: 56m 35s | Max: 58m 08s | Hits:  64%/2426  
      🟩 GCC11              Pass: 100%/2   | Total:  2h 00m | Avg:  1h 00m | Max:  1h 01m | Hits:  64%/2422  
      🟩 GCC12              Pass: 100%/2   | Total:  1h 56m | Avg: 58m 15s | Max: 59m 02s | Hits:  64%/2422  
      🟩 GCC13              Pass: 100%/11  | Total:  6h 45m | Avg: 36m 53s | Max:  1h 09m | Hits:  83%/13321 
      🟩 MSVC14.29          Pass: 100%/2   | Total:  2h 15m | Avg:  1h 07m | Max:  1h 10m | Hits:  13%/2072  
      🟩 MSVC14.42          Pass: 100%/2   | Total:  2h 36m | Avg:  1h 18m | Max:  1h 24m | Hits:  13%/2072  
      🟩 NVHPC24.7          Pass: 100%/2   | Total:  2h 11m | Avg:  1h 05m | Max:  1h 05m | Hits:  64%/2240  
    🟩 cxx_family
      🟩 Clang              Pass: 100%/17  | Total: 14h 53m | Avg: 52m 35s | Max: 59m 31s | Hits:  69%/20265 
      🟩 GCC                Pass: 100%/22  | Total: 17h 23m | Avg: 47m 24s | Max:  1h 09m | Hits:  74%/26656 
      🟩 MSVC               Pass: 100%/4   | Total:  4h 52m | Avg:  1h 13m | Max:  1h 24m | Hits:  13%/4144  
      🟩 NVHPC              Pass: 100%/2   | Total:  2h 11m | Avg:  1h 05m | Max:  1h 05m | Hits:  64%/2240  
    🟩 gpu
      🟩 h100               Pass: 100%/3   | Total:  1h 10m | Avg: 23m 20s | Max: 25m 53s | Hits:  87%/3633  
      🟩 rtx2080            Pass: 100%/34  | Total:  1d 10h | Avg:  1h 00m | Max:  1h 24m | Hits:  59%/39984 
      🟩 rtxa6000           Pass: 100%/8   | Total:  4h 08m | Avg: 31m 07s | Max:  1h 03m | Hits:  90%/9688  
    🟩 jobs
      🟩 Build              Pass: 100%/37  | Total:  1d 12h | Avg: 59m 06s | Max:  1h 24m | Hits:  60%/43617 
      🟩 DeviceLaunch       Pass: 100%/1   | Total: 21m 29s | Avg: 21m 29s | Max: 21m 29s | Hits:  99%/1211  
      🟩 GraphCapture       Pass: 100%/1   | Total: 16m 04s | Avg: 16m 04s | Max: 16m 04s | Hits:  99%/1211  
      🟩 HostLaunch         Pass: 100%/3   | Total:  1h 10m | Avg: 23m 38s | Max: 24m 07s | Hits:  99%/3633  
      🟩 TestGPU            Pass: 100%/3   | Total:  1h 05m | Avg: 21m 43s | Max: 22m 24s | Hits:  99%/3633  
    🟩 sm
      🟩 90                 Pass: 100%/3   | Total:  1h 10m | Avg: 23m 20s | Max: 25m 53s | Hits:  87%/3633  
      🟩 90;90a;100         Pass: 100%/1   | Total:  1h 09m | Avg:  1h 09m | Max:  1h 09m | Hits:  64%/1211  
    🟩 std
      🟩 17                 Pass: 100%/20  | Total: 19h 51m | Avg: 59m 35s | Max:  1h 12m | Hits:  58%/23455 
      🟩 20                 Pass: 100%/25  | Total: 19h 28m | Avg: 46m 44s | Max:  1h 24m | Hits:  74%/29850 
    
  • 🟩 thrust: Pass: 100%/45 | Total: 21h 10m | Avg: 28m 14s | Max: 58m 13s | Hits: 77%/80136

    🟩 cmake_options
      🟩 -DTHRUST_DISPATCH_TYPE=Force32bit Pass: 100%/2   | Total: 34m 17s | Avg: 17m 08s | Max: 23m 13s | Hits:  88%/3564  
    🟩 cpu
      🟩 amd64              Pass: 100%/43  | Total: 20h 19m | Avg: 28m 21s | Max: 58m 13s | Hits:  77%/76573 
      🟩 arm64              Pass: 100%/2   | Total: 51m 51s | Avg: 25m 55s | Max: 27m 19s | Hits:  76%/3563  
    🟩 ctk
      🟩 12.0               Pass: 100%/5   | Total:  2h 40m | Avg: 32m 04s | Max: 49m 30s | Hits:  72%/8901  
      🟩 12.5               Pass: 100%/2   | Total:  1h 33m | Avg: 46m 34s | Max: 46m 43s | Hits:  63%/3562  
      🟩 12.8               Pass: 100%/38  | Total: 16h 57m | Avg: 26m 46s | Max: 58m 13s | Hits:  78%/67673 
    🟩 cudacxx
      🟩 ClangCUDA18        Pass: 100%/2   | Total: 47m 03s | Avg: 23m 31s | Max: 24m 49s | Hits:  76%/3562  
      🟩 nvcc12.0           Pass: 100%/5   | Total:  2h 40m | Avg: 32m 04s | Max: 49m 30s | Hits:  72%/8901  
      🟩 nvcc12.5           Pass: 100%/2   | Total:  1h 33m | Avg: 46m 34s | Max: 46m 43s | Hits:  63%/3562  
      🟩 nvcc12.8           Pass: 100%/36  | Total: 16h 10m | Avg: 26m 57s | Max: 58m 13s | Hits:  78%/64111 
    🟩 cudacxx_family
      🟩 ClangCUDA          Pass: 100%/2   | Total: 47m 03s | Avg: 23m 31s | Max: 24m 49s | Hits:  76%/3562  
      🟩 nvcc               Pass: 100%/43  | Total: 20h 23m | Avg: 28m 27s | Max: 58m 13s | Hits:  77%/76574 
    🟩 cxx
      🟩 Clang14            Pass: 100%/4   | Total:  1h 51m | Avg: 27m 59s | Max: 29m 36s | Hits:  76%/7124  
      🟩 Clang15            Pass: 100%/2   | Total: 55m 17s | Avg: 27m 38s | Max: 28m 51s | Hits:  76%/3562  
      🟩 Clang16            Pass: 100%/2   | Total: 53m 25s | Avg: 26m 42s | Max: 27m 33s | Hits:  76%/3562  
      🟩 Clang17            Pass: 100%/2   | Total: 56m 56s | Avg: 28m 28s | Max: 29m 35s | Hits:  76%/3562  
      🟩 Clang18            Pass: 100%/7   | Total:  2h 23m | Avg: 20m 29s | Max: 29m 05s | Hits:  83%/12467 
      🟩 GCC7               Pass: 100%/2   | Total: 54m 07s | Avg: 27m 03s | Max: 27m 23s | Hits:  76%/3564  
      🟩 GCC8               Pass: 100%/1   | Total: 25m 39s | Avg: 25m 39s | Max: 25m 39s | Hits:  76%/1782  
      🟩 GCC9               Pass: 100%/2   | Total: 58m 33s | Avg: 29m 16s | Max: 30m 05s | Hits:  76%/3564  
      🟩 GCC10              Pass: 100%/2   | Total: 58m 17s | Avg: 29m 08s | Max: 30m 02s | Hits:  76%/3564  
      🟩 GCC11              Pass: 100%/2   | Total: 55m 23s | Avg: 27m 41s | Max: 28m 04s | Hits:  76%/3564  
      🟩 GCC12              Pass: 100%/2   | Total:  1h 03m | Avg: 31m 36s | Max: 32m 57s | Hits:  76%/3564  
      🟩 GCC13              Pass: 100%/10  | Total:  3h 17m | Avg: 19m 47s | Max: 30m 55s | Hits:  86%/17820 
      🟩 MSVC14.29          Pass: 100%/2   | Total:  1h 42m | Avg: 51m 03s | Max: 52m 36s | Hits:  54%/3550  
      🟩 MSVC14.42          Pass: 100%/3   | Total:  2h 21m | Avg: 47m 11s | Max: 58m 13s | Hits:  60%/5325  
      🟩 NVHPC24.7          Pass: 100%/2   | Total:  1h 33m | Avg: 46m 34s | Max: 46m 43s | Hits:  63%/3562  
    🟩 cxx_family
      🟩 Clang              Pass: 100%/17  | Total:  7h 01m | Avg: 24m 46s | Max: 29m 36s | Hits:  79%/30277 
      🟩 GCC                Pass: 100%/21  | Total:  8h 33m | Avg: 24m 25s | Max: 32m 57s | Hits:  81%/37422 
      🟩 MSVC               Pass: 100%/5   | Total:  4h 03m | Avg: 48m 43s | Max: 58m 13s | Hits:  58%/8875  
      🟩 NVHPC              Pass: 100%/2   | Total:  1h 33m | Avg: 46m 34s | Max: 46m 43s | Hits:  63%/3562  
    🟩 gpu
      🟩 h100               Pass: 100%/2   | Total: 29m 45s | Avg: 14m 52s | Max: 18m 32s | Hits:  88%/3564  
      🟩 rtx2080            Pass: 100%/33  | Total: 17h 01m | Avg: 30m 57s | Max: 52m 36s | Hits:  74%/58769 
      🟩 rtx4090            Pass: 100%/10  | Total:  3h 39m | Avg: 21m 58s | Max: 58m 13s | Hits:  85%/17803 
    🟩 jobs
      🟩 Build              Pass: 100%/38  | Total: 19h 41m | Avg: 31m 05s | Max: 58m 13s | Hits:  73%/67671 
      🟩 TestCPU            Pass: 100%/3   | Total: 46m 18s | Avg: 15m 26s | Max: 31m 18s | Hits:  90%/5338  
      🟩 TestGPU            Pass: 100%/4   | Total: 43m 09s | Avg: 10m 47s | Max: 11m 13s | Hits:  99%/7127  
    🟩 sm
      🟩 90                 Pass: 100%/2   | Total: 29m 45s | Avg: 14m 52s | Max: 18m 32s | Hits:  88%/3564  
      🟩 90;90a;100         Pass: 100%/1   | Total: 29m 39s | Avg: 29m 39s | Max: 29m 39s | Hits:  76%/1782  
    🟩 std
      🟩 17                 Pass: 100%/20  | Total: 10h 37m | Avg: 31m 53s | Max: 52m 36s | Hits:  72%/35611 
      🟩 20                 Pass: 100%/23  | Total:  9h 58m | Avg: 26m 02s | Max: 58m 13s | Hits:  80%/40961 
    
  • 🟩 cccl_c_parallel: Pass: 100%/2 | Total: 15m 52s | Avg: 7m 56s | Max: 13m 32s | Hits: 98%/304

    🟩 cpu
      🟩 amd64              Pass: 100%/2   | Total: 15m 52s | Avg:  7m 56s | Max: 13m 32s | Hits:  98%/304   
    🟩 ctk
      🟩 12.8               Pass: 100%/2   | Total: 15m 52s | Avg:  7m 56s | Max: 13m 32s | Hits:  98%/304   
    🟩 cudacxx
      🟩 nvcc12.8           Pass: 100%/2   | Total: 15m 52s | Avg:  7m 56s | Max: 13m 32s | Hits:  98%/304   
    🟩 cudacxx_family
      🟩 nvcc               Pass: 100%/2   | Total: 15m 52s | Avg:  7m 56s | Max: 13m 32s | Hits:  98%/304   
    🟩 cxx
      🟩 GCC13              Pass: 100%/2   | Total: 15m 52s | Avg:  7m 56s | Max: 13m 32s | Hits:  98%/304   
    🟩 cxx_family
      🟩 GCC                Pass: 100%/2   | Total: 15m 52s | Avg:  7m 56s | Max: 13m 32s | Hits:  98%/304   
    🟩 gpu
      🟩 rtx2080            Pass: 100%/2   | Total: 15m 52s | Avg:  7m 56s | Max: 13m 32s | Hits:  98%/304   
    🟩 jobs
      🟩 Build              Pass: 100%/1   | Total:  2m 20s | Avg:  2m 20s | Max:  2m 20s | Hits:  98%/152   
      🟩 Test               Pass: 100%/1   | Total: 13m 32s | Avg: 13m 32s | Max: 13m 32s | Hits:  98%/152   
    
  • 🟩 python: Pass: 100%/1 | Total: 46m 46s | Avg: 46m 46s | Max: 46m 46s

    🟩 cpu
      🟩 amd64              Pass: 100%/1   | Total: 46m 46s | Avg: 46m 46s | Max: 46m 46s
    🟩 ctk
      🟩 12.8               Pass: 100%/1   | Total: 46m 46s | Avg: 46m 46s | Max: 46m 46s
    🟩 cudacxx
      🟩 nvcc12.8           Pass: 100%/1   | Total: 46m 46s | Avg: 46m 46s | Max: 46m 46s
    🟩 cudacxx_family
      🟩 nvcc               Pass: 100%/1   | Total: 46m 46s | Avg: 46m 46s | Max: 46m 46s
    🟩 cxx
      🟩 GCC13              Pass: 100%/1   | Total: 46m 46s | Avg: 46m 46s | Max: 46m 46s
    🟩 cxx_family
      🟩 GCC                Pass: 100%/1   | Total: 46m 46s | Avg: 46m 46s | Max: 46m 46s
    🟩 gpu
      🟩 rtx2080            Pass: 100%/1   | Total: 46m 46s | Avg: 46m 46s | Max: 46m 46s
    🟩 jobs
      🟩 Test               Pass: 100%/1   | Total: 46m 46s | Avg: 46m 46s | Max: 46m 46s
    

👃 Inspect Changes

Modifications in project?

Project
CCCL Infrastructure
libcu++
CUB
+/- Thrust
CUDA Experimental
python
CCCL C Parallel Library
Catch2Helper

Modifications in project or dependencies?

Project
CCCL Infrastructure
libcu++
+/- CUB
+/- Thrust
CUDA Experimental
+/- python
+/- CCCL C Parallel Library
+/- Catch2Helper

🏃‍ Runner counts (total jobs: 93)

# Runner
66 linux-amd64-cpu16
9 windows-amd64-cpu16
6 linux-amd64-gpu-rtxa6000-latest-1
4 linux-arm64-cpu16
3 linux-amd64-gpu-h100-latest-1
3 linux-amd64-gpu-rtx4090-latest-1
2 linux-amd64-gpu-rtx2080-latest-1

@bernhardmgruber bernhardmgruber merged commit 8c9b0a9 into NVIDIA:main Feb 22, 2025
106 of 109 checks passed
@bernhardmgruber bernhardmgruber deleted the drop_thrust_cuda_util_iters branch February 23, 2025 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Breaking change thrust For all items related to Thrust.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants