-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
do not try to use clang-19's support for c++26 pack indexing #3888
Merged
ericniebler
merged 1 commit into
NVIDIA:main
from
ericniebler:work-around-clang-19-pack-indexing-bug
Feb 21, 2025
Merged
do not try to use clang-19's support for c++26 pack indexing #3888
ericniebler
merged 1 commit into
NVIDIA:main
from
ericniebler:work-around-clang-19-pack-indexing-bug
Feb 21, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clang claims to support pack indexing by defining `__cpp_pack_indexing`, but then it fails to parse pack indexing expressions.
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
/ok to test |
pciolkosz
approved these changes
Feb 21, 2025
🟩 CI finished in 1h 08m: Pass: 100%/158 | Total: 1d 05h | Avg: 11m 10s | Max: 37m 14s | Hits: 81%/248136
|
Project | |
---|---|
CCCL Infrastructure | |
+/- | libcu++ |
CUB | |
Thrust | |
CUDA Experimental | |
python | |
CCCL C Parallel Library | |
Catch2Helper |
Modifications in project or dependencies?
Project | |
---|---|
CCCL Infrastructure | |
+/- | libcu++ |
+/- | CUB |
+/- | Thrust |
+/- | CUDA Experimental |
+/- | python |
+/- | CCCL C Parallel Library |
+/- | Catch2Helper |
🏃 Runner counts (total jobs: 158)
# | Runner |
---|---|
111 | linux-amd64-cpu16 |
15 | windows-amd64-cpu16 |
10 | linux-arm64-cpu16 |
8 | linux-amd64-gpu-rtx2080-latest-1 |
6 | linux-amd64-gpu-rtxa6000-latest-1 |
5 | linux-amd64-gpu-h100-latest-1 |
3 | linux-amd64-gpu-rtx4090-latest-1 |
bernhardmgruber
approved these changes
Feb 21, 2025
Successfully created backport PR for |
github-actions bot
pushed a commit
that referenced
this pull request
Feb 21, 2025
clang claims to support pack indexing by defining `__cpp_pack_indexing`, but then it fails to parse pack indexing expressions. (cherry picked from commit c267f32)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
clang claims to support pack indexing by defining
__cpp_pack_indexing
, but then it fails to parse pack indexing expressions.Description
this is an attempt to fix the problem described in nvbug#4864896
Checklist