-
Notifications
You must be signed in to change notification settings - Fork 2.9k
feat: support exp manager checkpointing with object store via Multi-Storage Client #12747
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: jayya2 <jayya2@users.noreply.github.com>
Signed-off-by: jayya2 <jayya2@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall ok, but the code is getting super complicated.
Can you avoid trying to add is_msc_* to every single check and simply separate the code paths to be completely independent of each other if msc is there or not?
Right now this mix match of merging msc logic with older logic makes the code unreadable.
Signed-off-by: jayya2 <jayya2@users.noreply.github.com>
Signed-off-by: jayya2 <jayya2@users.noreply.github.com>
Signed-off-by: jayya2 <jayya2@users.noreply.github.com>
@titu1994
Let me know if further refactoring is required, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Much cleaner than before, thank you !
@ericharper @titu1994 @ko3n1g are the infra issues resolved? saw some of the tests retried and passed but still 2 failing but seems unrelated to this change |
Signed-off-by: Jay Yang <jayya@nvidia.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Re-approving
Important
The
Update branch
button must only be pressed in very rare occassions.An outdated branch is never blocking the merge of a PR.
Please reach out to the automation team before pressing that button.
What does this PR do ?
Add support for using multi-storage-client for the Exp Manager checkpointing mechanism so that users who haven't migrated to new checkpoints can still take advantage of the object stores.
Collection: [Note which collection this PR will affect]
Changelog
Usage
# Add a code snippet demonstrating how to use this
GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information